Fix TypeScript errors in ssr.ts & when using vue-tsc #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create AppPageProps that contain all shared props. This avoids having to import SharedProps whenever PageProps are being used
…add template macro types
Use the correct method overload for the route properties during SSR and add type for page file imports
Fixes various issues that would prevent typescript from compiling when vue-tsc is being used.
tnylea
reviewed
Mar 19, 2025
| @@ -41,7 +41,7 @@ | |||
| // "typeRoots": [], /* Specify multiple folders that act like './node_modules/@types'. */ | |||
| "types": [ | |||
| "vite/client", | |||
| "vue/tsx", | |||
| "node", | |||
There was a problem hiding this comment.
Can you explain to me what this is doing here?
Everything else is looking really good. Thanks for the PR.
There was a problem hiding this comment.
I could not find any source for the vue/tsx types within the installed packages, nor any reference in the official Vue docs recommending setting this as a value See TS docs for Vue. I assume this value was set by mistake or might be a remnant from an outdated Vue version.
The addition of the node types is simply there to make the compiler aware of the global object in ssr.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses various issues with the current implementation of the ssr.ts, global d.ts and various template files.
route,$inertia,$pageand$headManagervue-tscinto their build step