feat: make free plans never expire#42
Merged
Merged
Conversation
Free plans now have ends_at and trial_ends_at set to null, meaning they never expire and don't require renewal. - Update newPlanSubscription() to set null dates for free plans - Update changePlan() to set null dates when switching to free plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Free plans should not have an expiration date since there's nothing to bill. This PR ensures that subscriptions to free plans have
ends_atandtrial_ends_atset tonull, making them perpetual.Changes
HasPlanSubscriptions::newPlanSubscription()- Setsends_atandtrial_ends_attonullwhen subscribing to a free planSubscription::changePlan()- Setsends_atandtrial_ends_attonullwhen changing to a free planRationale
Previously, free plans were treated like paid plans with a billing period, causing them to "expire" even though there's no payment involved. This led to:
Behavior
ends_atnull(never expires)