Add support for deleted records before processing #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
I would appreciate some real app testing to confirm this is working properly, and +1 this PR to confirm. Cheers! |
Contributor
|
@lardawge thanks, will test next week |
lardawge
force-pushed
the
ls/add-support-for-removed-records
branch
from
c0f24bd to
1c5c1cb
Compare
gstokkink
reviewed
Aug 18, 2025
gstokkink
reviewed
Aug 18, 2025
gstokkink
reviewed
Aug 18, 2025
gstokkink
reviewed
Aug 18, 2025
gstokkink
reviewed
Aug 18, 2025
Contributor
|
@lardawge testing the branch now, note that there's a bunch of typoes in the PR, see comments |
Owner
Author
|
@gstokkink Thanks for taking a look. Sorted the spelling issues. Let me know how the testing goes. |
Contributor
|
@lardawge it works fine, thanks 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support based on requests for this feature. This will suppress the NotFoundError when a record is not found.
There is a configuration available if you need that functionality for any reason.