Fix our legion config to build against our hdf5#90
Merged
Conversation
Member
Author
Member
|
Is this one of the repos whose CI has been moved to gitlab? |
Member
Author
I looked on gitlab and didn't see it. But even if it's there, there's no reason why this CI shouldn't pass. |
Member
|
Ok. I didn't know if something had changed to accommodate gitlab that was incompatible with travis. |
Member
Author
|
Good suggestion, but I don't think that's the issue. |
Contributor
|
@cferenba retry? |
|
@cferenba :did you have to do this changes because of some kind of issues with the FindHDF5 from cmake? |
Member
Author
|
@ipdemes : yes, the FindHDF5 from cmake wasn't behaving as expected. |
|
@cferenba I see, I have had some similar experience myself. Looks good to me. |
ipdemes
approved these changes
Nov 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the configuration for legion to correctly find our hdf5 build (if requested).
@ktsai7 @ipdemes : please review. @opensdh : FYI.