Skip to content

Fix our legion config to build against our hdf5#90

Merged
ipdemes merged 1 commit intomasterfrom
fix/legion-with-hdf5
Nov 25, 2019
Merged

Fix our legion config to build against our hdf5#90
ipdemes merged 1 commit intomasterfrom
fix/legion-with-hdf5

Conversation

@cferenba
Copy link
Copy Markdown
Member

@cferenba cferenba commented Nov 8, 2019

This modifies the configuration for legion to correctly find our hdf5 build (if requested).

@ktsai7 @ipdemes : please review. @opensdh : FYI.

@cferenba
Copy link
Copy Markdown
Member Author

As I suspected, something has changed in the environment in the past few months, such that the HEAD of master passed CI on Aug 9, but doesn't pass now (see #89 and #91).

What to do?

@cmsquared
Copy link
Copy Markdown
Member

cmsquared commented Nov 12, 2019

Is this one of the repos whose CI has been moved to gitlab?

@cferenba
Copy link
Copy Markdown
Member Author

Is this one of the repo's whose CI has been moved to gitlab?

I looked on gitlab and didn't see it. But even if it's there, there's no reason why this CI shouldn't pass.

@cmsquared
Copy link
Copy Markdown
Member

Ok. I didn't know if something had changed to accommodate gitlab that was incompatible with travis.

@cferenba
Copy link
Copy Markdown
Member Author

Good suggestion, but I don't think that's the issue.

@ktsai7
Copy link
Copy Markdown
Contributor

ktsai7 commented Nov 25, 2019

@cferenba retry?

@cferenba
Copy link
Copy Markdown
Member Author

@ktsai7 : looks like the build reran and passed, thanks!

@ktsai7 @ipdemes @tuxfan : would one of you please review and merge?

@ipdemes
Copy link
Copy Markdown

ipdemes commented Nov 25, 2019

@cferenba :did you have to do this changes because of some kind of issues with the FindHDF5 from cmake?

@cferenba
Copy link
Copy Markdown
Member Author

@ipdemes : yes, the FindHDF5 from cmake wasn't behaving as expected.

@ipdemes
Copy link
Copy Markdown

ipdemes commented Nov 25, 2019

@cferenba I see, I have had some similar experience myself. Looks good to me.

@ktsai7 ktsai7 requested a review from ipdemes November 25, 2019 20:42
@ipdemes ipdemes merged commit 6e0f5af into master Nov 25, 2019
@ktsai7 ktsai7 deleted the fix/legion-with-hdf5 branch November 26, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants