Bugfix Earley: handle ambiguity from ignored tokens#1577
Open
chanicpanic wants to merge 2 commits intolark-parser:masterfrom
Open
Bugfix Earley: handle ambiguity from ignored tokens#1577chanicpanic wants to merge 2 commits intolark-parser:masterfrom
chanicpanic wants to merge 2 commits intolark-parser:masterfrom
Conversation
chanicpanic
changed the title
Contributor
Author
|
I realized that the issue also applies to ambiguity involving ignores anywhere in the string. The parser now produces previously unsurfaced derivations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1576: an edge case in which start symbol nodes were not shared between start symbol items that completed at different parts of the string due to ignores.
Thanks @kwilinsi for the great MCVE!