Fix macro leak and quiet the pragma in freestanding builds - #2
Merged
patkenneally merged 5 commits intoAug 25, 2026
Merged
Conversation
This was referenced Aug 21, 2026
patkenneally
force-pushed
the
fix/freestanding-packet-decl-macro-leak
branch
5 times, most recently
from
August 25, 2026 00:10
fa3d45e to
6d4b971
Compare
patkenneally
force-pushed
the
fix/freestanding-packet-decl-macro-leak
branch
from
August 25, 2026 00:19
6d4b971 to
a5bab9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes for the freestanding build.
The
#ifndef EIGEN_FREESTANDINGguard added in b037445 accidentally swallowed upstream's#undef PACKET_DECL_COND*lines, so in freestanding builds those four macros leak out ofEigen/Coreand one of them collides inGeneralMatrixVector.h. Every translation unit warns about it. Fixed by undefining them at file scopeinstead, after the last use. Upstream's lines are left alone so future merges against 3.4 don't conflict.
The other one:
all_freestanding.hppprinted "Eigen in hosted mode" (or freestanding) on every single translation unit, which buries anything useful in the build log. Now behindEIGEN_FREESTANDING_VERBOSEif you want it back.Checked both modes compile clean with and without
EIGEN_FREESTANDING.