Refactor/update numeral#74
Merged
last-partizan merged 3 commits intolast-partizan:masterfrom Jul 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the numeral module to improve type safety and code consistency by replacing magic numbers with named constants and enhancing type annotations.
- Introduces
FORMS_COUNTconstant to replace magic number 3 - Replaces hardcoded gender values (1, 2) with named constants (MALE, FEMALE)
- Removes unused parameter
_genderfromin_words_floatfunction - Improves type annotations and adds type casting for better type safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.