[codex] Add G-Stack skill filter by ryota-murakami · Pull Request #152 · laststance/skills-desktop

ryota-murakami · 2026-05-10T12:41:00Z

Summary

Add a G-Stack skill type filter alongside Symlinked, Local, and Orphan in the installed skills agent view.
Reuse the same per-agent G-Stack attribution helper for the card badge and the filter so sibling-agent state cannot bleed across rows.
Ignore static-storybook/ and make pnpm lint fail on any ESLint warning with --max-warnings 0.
Clean up the existing lint warnings that would fail the stricter lint gate.

Validation

pnpm exec vitest run --project node src/renderer/src/redux/selectors.test.ts src/renderer/src/components/skills/skillsListHelpers.test.ts src/renderer/src/components/skills/skillItemHelpers.test.ts
pnpm exec vitest run --project browser src/renderer/src/components/layout/MainContent.browser.test.tsx
pnpm lint
pnpm validate
/review clean

Summary by CodeRabbit

リリースノート

新機能
- インストール済みエージェントビューのスキル種別フィルタに「G-Stack」オプションを追加しました。
テスト
- E2Eテストのタイミング信頼性を改善しました。
- スキルフィルタリング機能のテストカバレッジを拡張しました。
その他
- リント設定を更新し、警告を厳格に管理するようにしました。

vercel · 2026-05-10T12:41:05Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
skills-desktop	Ready	Preview, Comment	May 10, 2026 2:49pm

coderabbitai · 2026-05-10T12:41:06Z

Warning

Rate limit exceeded

@ryota-murakami has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 33 minutes and 35 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c22aea56-b36f-4f9c-9e8a-40e928998067

📥 Commits

Reviewing files that changed from the base of the PR and between a70c771 and 9b822f5.

📒 Files selected for processing (4)

src/renderer/src/components/layout/MainContent.browser.test.tsx
src/renderer/src/components/layout/MainContent.tsx
src/renderer/src/styles/globals.css
tailwind.config.ts

Walkthrough

This PR adds a "G-Stack" skill-type filter option to the installed agent view. It introduces a centralized isGStackManagedForAgent helper for consistent G-Stack detection across the UI, integrates it into the selector layer, updates the dropdown component, refactors existing badge logic to use the new helper, and adds comprehensive test coverage. Minor e2e fixes and config updates are also included.

Changes

G-Stack Filter Feature

Layer / File(s)	Summary
Type Contract `src/renderer/src/redux/slices/uiSlice.ts`	`SkillTypeFilter` union expanded to include `'gstack'` option.
G-Stack Detection Utility `src/renderer/src/utils/gstackSkill.ts`	New module exports `isGStackManagedForAgent` helper that detects G-Stack-managed skills by testing symlink paths against `skills/gstack` pattern, with per-agent eligibility checks.
Selector Integration `src/renderer/src/redux/selectors.ts`	`selectFilteredSkills` adds `gstack` filtering branch delegating to `isGStackManagedForAgent`; documentation updated.
UI Dropdown `src/renderer/src/components/layout/MainContent.tsx`, `src/renderer/src/components/layout/MainContent.browser.test.tsx`	Adds `gstack` option to filter dropdown with label "G-Stack" and `bg-sky-400` dot styling; test coverage expanded for G-Stack radio item rendering.
Helper Refactoring `src/renderer/src/components/skills/skillItemHelpers.ts`, `src/renderer/src/components/skills/skillsListHelpers.ts`	Removes inline G-Stack detection logic from `skillItemHelpers` and uses `isGStackManagedForAgent` instead; adds `SKILL_TYPE_FILTER_LABELS` map for human-readable filter names in empty-state messages.
Test Coverage `src/renderer/src/redux/selectors.test.ts`, `src/renderer/src/components/skills/skillsListHelpers.test.ts`	Adds `gstack` test cases for selector filtering (symlink and local skill paths), agent-scoped filtering regression test, and empty-state message validation.
E2E & Config `e2e/spec/hide-agents.e2e.ts`, `e2e/spec/regression.e2e.ts`, `e2e/spec/sync.e2e.ts`, `package.json`, `.gitignore`	Reorders e2e imports; converts `appWindow.evaluate` callbacks to `async` for proper promise handling in RAF-based delays; updates eslint config to fail on warnings (`--max-warnings 0`); adds `static-storybook/` to gitignore.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

laststance/skills-desktop#137: Modifies G-Stack badge detection and skill-item visibility logic with overlapping skillItemHelpers changes.
laststance/skills-desktop#146: Updates SkillTypeFilter union and selector logic for a new filter variant, touching the same uiSlice and selectors files.
laststance/skills-desktop#145: Introduces the e2e test files modified in this PR (hide-agents.e2e.ts, regression.e2e.ts, sync.e2e.ts).

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PRタイトル「[codex] Add G-Stack skill filter」は、変更セットの主要な目的（Installed agentビューへのG-Stackスキルタイプフィルターの追加）を明確かつ簡潔に説明しており、実装内容と一致している。
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/add-gstack-filters

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov-commenter · 2026-05-10T12:42:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.01%. Comparing base (1df5a12) to head (9b822f5).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   51.64%   52.01%   +0.37%     
==========================================
  Files         173      174       +1     
  Lines        4202     4216      +14     
  Branches      892      893       +1     
==========================================
+ Hits         2170     2193      +23     
+ Misses       1843     1831      -12     
- Partials      189      192       +3

Flag	Coverage Δ
unittests	`52.01% <100.00%> (+0.37%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ryota-murakami · 2026-05-10T12:44:45Z

@coderabbitai full review

coderabbitai · 2026-05-10T12:44:49Z

✅ Actions performed

Full review triggered.

ryota-murakami · 2026-05-10T14:22:48Z

@coderabbitai full review

coderabbitai · 2026-05-10T14:22:53Z

✅ Actions performed

Full review triggered.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/renderer/src/components/layout/MainContent.tsx`:
- Line 111: Replace the hardcoded Tailwind class "bg-sky-400" used for the
'gstack' dot (in the array entry with value 'gstack' / label 'G-Stack' in
MainContent.tsx) with a semantic theme token/class that derives from your OKLCH
theme axes; add or reuse a semantic token like "bg-dot-gstack" (or a shadcn
token) implemented using the OKLCH formula with --theme-hue and --theme-chroma
(e.g., oklch(... calc(var(--theme-chroma) * K) var(--theme-hue))) in your
CSS/token definitions, then swap dotClass to that token name instead of
"bg-sky-400" so the color follows the OKLCH theme system.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ac5c78db-7588-42e3-8671-16a67e5766f8

📥 Commits

Reviewing files that changed from the base of the PR and between 1df5a12 and a70c771.

📒 Files selected for processing (14)

.gitignore
e2e/spec/hide-agents.e2e.ts
e2e/spec/regression.e2e.ts
e2e/spec/sync.e2e.ts
package.json
src/renderer/src/components/layout/MainContent.browser.test.tsx
src/renderer/src/components/layout/MainContent.tsx
src/renderer/src/components/skills/skillItemHelpers.ts
src/renderer/src/components/skills/skillsListHelpers.test.ts
src/renderer/src/components/skills/skillsListHelpers.ts
src/renderer/src/redux/selectors.test.ts
src/renderer/src/redux/selectors.ts
src/renderer/src/redux/slices/uiSlice.ts
src/renderer/src/utils/gstackSkill.ts

feat: add G-Stack skill filter

a70c771

vercel Bot deployed to Preview May 10, 2026 12:41 View deployment

ryota-murakami marked this pull request as ready for review May 10, 2026 12:44

coderabbitai Bot requested changes May 10, 2026

View reviewed changes

Comment thread src/renderer/src/components/layout/MainContent.tsx Outdated

fix: use themed G-Stack filter color

9b822f5

vercel Bot deployed to Preview May 10, 2026 14:49 View deployment

coderabbitai Bot approved these changes May 10, 2026

View reviewed changes

ryota-murakami merged commit 49beef4 into main May 10, 2026
9 checks passed

ryota-murakami deleted the codex/add-gstack-filters branch May 10, 2026 14:51

coderabbitai Bot mentioned this pull request May 20, 2026

Add installed repo and exclude filters #168

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[codex] Add G-Stack skill filter#152

[codex] Add G-Stack skill filter#152
ryota-murakami merged 2 commits into
mainfrom
codex/add-gstack-filters

ryota-murakami commented May 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented May 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 10, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

codecov-commenter commented May 10, 2026 •

edited

Loading

Uh oh!

ryota-murakami commented May 10, 2026

Uh oh!

coderabbitai Bot commented May 10, 2026

Uh oh!

ryota-murakami commented May 10, 2026

Uh oh!

coderabbitai Bot commented May 10, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ryota-murakami commented May 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

リリースノート

Uh oh!

vercel Bot commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

codecov-commenter commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ryota-murakami commented May 10, 2026

Uh oh!

coderabbitai Bot commented May 10, 2026

Uh oh!

ryota-murakami commented May 10, 2026

Uh oh!

coderabbitai Bot commented May 10, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ryota-murakami commented May 10, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented May 10, 2026 •

edited

Loading

coderabbitai Bot commented May 10, 2026 •

edited

Loading

codecov-commenter commented May 10, 2026 •

edited

Loading