Skip to content

Switch to Installed tab from Marketplace sidebar#156

Merged
ryota-murakami merged 1 commit into
mainfrom
codex/marketplace-sidebar-installed-tab
May 11, 2026
Merged

Switch to Installed tab from Marketplace sidebar#156
ryota-murakami merged 1 commit into
mainfrom
codex/marketplace-sidebar-installed-tab

Conversation

@ryota-murakami

@ryota-murakami ryota-murakami commented May 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • switch SourceCard/Universal navigation back to the Installed tab before clearing filters
  • switch individual agent sidebar clicks back to Installed before applying the agent filter
  • add browser-mode regression coverage for SourceCard and AgentItem Marketplace navigation

Verification

  • pnpm vitest run src/renderer/src/components/sidebar/AgentItem.browser.test.tsx src/renderer/src/components/sidebar/SourceCard.browser.test.tsx --browser.headless
  • pnpm lint
  • pnpm validate
  • pnpm test:e2e

Summary by CodeRabbit

リリースノート

  • New Features

    • サイドバーのアイテムをクリック時に、アクティブタブが「installed」に自動切り替わるようになりました。マーケットプレイスなど他のタブ閲覧中でも、シームレスに目的のコンポーネントへナビゲートできます。
  • Tests

    • サイドバーナビゲーション動作の新規テストを追加しました。

Review Change Stack

@vercel

vercel Bot commented May 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
skills-desktop Ready Ready Preview, Comment May 11, 2026 6:51pm

Request Review

@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: eec6c3fd-34f8-41d6-a1e9-886a0d66b22d

📥 Commits

Reviewing files that changed from the base of the PR and between e3db009 and 73c432b.

📒 Files selected for processing (4)
  • src/renderer/src/components/sidebar/AgentItem.browser.test.tsx
  • src/renderer/src/components/sidebar/AgentItem.tsx
  • src/renderer/src/components/sidebar/SourceCard.browser.test.tsx
  • src/renderer/src/components/sidebar/SourceCard.tsx

Walkthrough

AgentItem と SourceCard コンポーネントが uiSlice の setActiveTab アクションをインポートして、クリックハンドラー内で activeTab を installed に設定するようになりました。AgentItem.browser.test.tsx と SourceCard.browser.test.tsx に、この状態遷移をテストする新しいテストスイートが追加されています。

Changes

Sidebar Navigation State

Layer / File(s) Summary
AgentItem Navigation
src/renderer/src/components/sidebar/AgentItem.tsx
uiSlice から setActiveTab をインポート。handleClickagent.exists 確認後に setActiveTab('installed') を dispatch します。
AgentItem Navigation Test
src/renderer/src/components/sidebar/AgentItem.browser.test.tsx
UI の activeTab を marketplace に設定してからクリックイベントをトリガーし、Redux state の activeTab が installed に、selectedAgentId が claude-code に変わることを検証します。
SourceCard Navigation
src/renderer/src/components/sidebar/SourceCard.tsx
uiSlice から setActiveTab をインポート。handlePathClicksetActiveTab('installed') を最初に dispatch してから selectedAgent を null、searchQuery を空文字にリセットします。
SourceCard Navigation Test
src/renderer/src/components/sidebar/SourceCard.browser.test.tsx
Electron IPC グローバルスタブ、Redux ストアファクトリー、コンポーネント描画ユーティリティを提供。marketplace state からのクリックで activeTab が installed、selectedAgent が null、searchQuery が空文字に遷移することを検証します。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • laststance/skills-desktop#59: uiSlice の activeTab/setActiveTab 変更に直接依存し、AgentItem/SourceCard からの dispatch は PR #59 の uiSlice 実装に基づいています。
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed タイトルはプルリクエストの主要な変更内容を正確に反映している。MarketplaceサイドバーからInstalledタブへの切り替え機能追加と、それに関連するテスト追加が実装されている。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/marketplace-sidebar-installed-tab

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.62%. Comparing base (e3db009) to head (73c432b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   53.01%   53.62%   +0.60%     
==========================================
  Files         178      178              
  Lines        4493     4496       +3     
  Branches      930      931       +1     
==========================================
+ Hits         2382     2411      +29     
+ Misses       1911     1881      -30     
- Partials      200      204       +4     
Flag Coverage Δ
unittests 53.62% <100.00%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryota-murakami ryota-murakami merged commit d5c0e75 into main May 11, 2026
9 checks passed
@ryota-murakami ryota-murakami deleted the codex/marketplace-sidebar-installed-tab branch May 11, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants