feat: marketplace incremental search with debounced live results#210
Merged
Conversation
The '/ship is for code commits/PRs only' phrase implied every main commit must route through /ship. Drop it so per-fix atomic commits can land directly; the /electron-release version-bump ownership rule stays intact.
…ance Wrap-up of the /design-review audit of the marketplace search surface. Rule B (Empty States) codifies why a zero-result search stays one quiet line — an expected miss is not a failure — while icon+heading is reserved for real errors. Rule A (Inputs) plus a Polish Backlog entry log the native type=search blue × as an accepted low-priority, palette-matched-chrome item rather than a fix-on-sight violation.
Button-less search that fires a debounced `skills find` on each keystroke.
- useDebouncedCallback hook ({run, cancel}) — debounce the callback, not the
value, per the repo's no-effect lint rules
- MarketplaceSearch: incremental search wired through onChange; Search<->Loader2
icon morph; clears back to the leaderboard on empty
- marketplaceSlice: latest-wins guard drops out-of-order CLI responses;
clearSearchResults resets both status and error so a failed query's banner
cannot outlive the box
- SkillsMarketplace: no-flash refine (keeps prior results while re-searching)
- SEARCH_DEBOUNCE_MS constant (300ms)
- Tests: slice latest-wins/clear paths, debounce primitive, composed search
Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Walkthroughマーケットプレイス検索をボタン/Enter駆動から、入力変更のたびにデバウンス済みのリモート検索を自動実行する方式へ移行。新フック Changesインクリメンタル検索のデバウンス化
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 66.75% 67.15% +0.39%
==========================================
Files 198 199 +1
Lines 6146 6165 +19
Branches 1388 1390 +2
==========================================
+ Hits 4103 4140 +37
+ Misses 1623 1603 -20
- Partials 420 422 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Button-less incremental search for the Marketplace tab. Each keystroke fires a debounced
skills find; results stream into the panel with no submit button.Changes
{ run, cancel }) — debounces the callback, fired fromonChange, per the repo's no-effect lint rulesclearSearchResultsnow resets bothstatusanderrorso a failed query's banner can't outlive the boxSEARCH_DEBOUNCE_MS= 300msTests
pnpm validategreen (lint / 1421 tests / typecheck / dead-code)Also folds in two small doc commits from the same session (CLAUDE.md
/shipframing, DESIGN.md empty-state + form-chrome rules).Note: no version bump — releases are owned by
/electron-release.🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート
New Features
Bug Fixes
Documentation