Add JSON schema validation to reject unknown fields#32
Merged
travier merged 2 commits intolatchset:mainfrom Jan 29, 2026
Merged
Add JSON schema validation to reject unknown fields#32travier merged 2 commits intolatchset:mainfrom
travier merged 2 commits intolatchset:mainfrom
Conversation
Contributor
Author
|
@puiterwijk: please take a look when possible. |
sergio-correia
force-pushed
the
validation
branch
from
7b892fd to
52e41cb
Compare
Signed-off-by: Sergio Correia <scorreia@redhat.com>
Adds serde(deny_unknown_fields) attribute to TPM2Config to catch typos and invalid field names in JSON configuration. Previously, invalid fields like "pcrs_ids" were silently ignored, which could lead to unexpected behavior. Signed-off-by: Sergio Correia <scorreia@redhat.com>
sergio-correia
force-pushed
the
validation
branch
from
52e41cb to
545a01f
Compare
travier
approved these changes
Jan 27, 2026
Member
travier
left a comment
travier
left a comment
There was a problem hiding this comment.
I'm OK with that but this might mean that we can not extend this config in the future if we want to change the format. I don't know where/how it's used right now.
Contributor
Author
|
Could you please elaborate on your concern? The validation only applies to encryption input ( |
Member
|
Thanks for the details. Makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds serde(deny_unknown_fields) attribute to TPM2Config to catch
typos and invalid field names in JSON configuration. Previously,
invalid fields like "pcrs_ids" were silently ignored, which could
lead to unexpected behavior.