openssl: handle NULL in jose_openssl_jwk_from_EC_KEY gracefully #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for your PR @a3f. Could you please rebase master branch to check if CI issue in your PR is fixed? |
We already check that the RSA *key is not NULL in jose_openssl_jwk_from_RSA(), but fail to do so for EC_KEY *key in jose_openssl_jwk_from_EC_KEY(). But EVP_PKEY_get0_EC_KEY() can return NULL too, e.g., if the EVP_PKEY comes from an OpenSSL provider that is not creating a keymgmt instance for a public key and the default provider is not loaded[1]. Instead of crashing inside OpenSSL when we pass a NULL pointer to EC_KEY_get0_private_key(), detect this case and return gracefully. [1]: openssl/openssl#25679 Signed-off-by: Ahmad Fatoum <[email protected]>
Contributor
Author
|
I have rebased, CI run needs maintainer approval. |
sarroutbi
approved these changes
Jul 9, 2025
Collaborator
sarroutbi
left a comment
sarroutbi
left a comment
There was a problem hiding this comment.
LGTM. @sergio-correia, PTAL
sergio-correia
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already check that the
RSA *keyis notNULLinjose_openssl_jwk_from_RSA(), but fail to do so forEC_KEY *keyinjose_openssl_jwk_from_EC_KEY().But
EVP_PKEY_get0_EC_KEY()can returnNULLtoo, e.g., if theEVP_PKEYcomes from an OpenSSL provider that is not creating a keymgmt instance for a public key and the default provider is not loaded1.Instead of crashing inside OpenSSL when we pass a NULL pointer to
EC_KEY_get0_private_key(), detect this case and return gracefully.