Really update to edition 2024 #187
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires updating bindgen to 0.71 as well. Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Simo Sorce <[email protected]>
|
sounds like there are a bit more places that need to be fixed to really work. Sorry I missed that initially. |
Signed-off-by: Simo Sorce <[email protected]>
|
Unfortunately bindgen is still not 2024 compliant. |
These bindings make bindgen emit a special __BindgenBitfieldUnit structure and code that are not 2024 edition safe yet. Because we do not need any of the structures and unions that cause this, let's just mask them out for now by turning these structus into opaque sized blobs. Signed-off-by: Simo Sorce <[email protected]>
|
I guess we'll keep this feature in draft for a little while longer, given c10s and some Fedora versions do not have a rust version new enough anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires updating bindgen to 0.71 as well.
Description
Somehow the previous PR ended up missing the critical change to Cargo.toml that actually really switched editions, even though the migration preparation work was all done.
Checklist
Test suite updated with functionality testsTest suite updated with negative testsDocumentation was updatedReviewer's checklist: