Skip to content

Update tests#1284

Merged
mbertucci47 merged 13 commits intomainfrom
UF-updatetests
Apr 1, 2026
Merged

Update tests#1284
mbertucci47 merged 13 commits intomainfrom
UF-updatetests

Conversation

@u-fischer
Copy link
Copy Markdown
Member

@u-fischer u-fischer commented Mar 28, 2026

The one still failing (zhnumber) is font dependant and works for me on windows ...

delimset will fail again once the author updates the package.

Copy link
Copy Markdown
Collaborator

@mbertucci47 mbertucci47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this file deleted?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were actually two reference files for luatex: this one and a newer prooftrees-01.struct.xml and this confused the checks. (No idea why and when it happen, I simply cleaned up when I saw that).

Layout:Placement="Inline"
>
<AssociatedFile name="mathml-2.xml" xmlns="">
<math xmlns="http://www.w3.org/1998/Math/MathML"> <munder> <mi>𝑀</mi> <mo>_</mo> </munder> </math>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's causing the extra mrow and mspace? It seems different than the other diffs where just a number is changing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho this is because of the spacing changes in luatex in texlive 2026 (which now inserts an italic correction sometimes).

<AssociatedFile name="tag-AFfile1.tex" xmlns="">
$\phi $
</AssociatedFile>
<?MarkedContent page="1" ?>φ
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong since the PDF output is a normal phi, not a varphi

@mbertucci47
Copy link
Copy Markdown
Collaborator

I think delimset has been updated so that test can be updated now.

@mbertucci47
Copy link
Copy Markdown
Collaborator

I am also confused why zhnumber worked before but only recently started failing

@mbertucci47
Copy link
Copy Markdown
Collaborator

I went ahead and updated the delimset test so I think this can be merged now, as long as no one has any ideas about the phi/varphi change

@u-fischer
Copy link
Copy Markdown
Member Author

someone will have to recreate the zhnumber test, as I wrote I seem to have on windows a newer (better) version of the font used in the test.

@mbertucci47
Copy link
Copy Markdown
Collaborator

I've updated the zhnumber test in a branch I'm about to make a PR from so I'll go ahead and merge here.

@mbertucci47 mbertucci47 merged commit 982b414 into main Apr 1, 2026
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants