Skip to content

Add a compiler option to modify operations#847

Draft
dlindhol wants to merge 1 commit into
masterfrom
compiler
Draft

Add a compiler option to modify operations#847
dlindhol wants to merge 1 commit into
masterfrom
compiler

Conversation

@dlindhol

Copy link
Copy Markdown
Member

This seems like a simple yet powerful way to construct an AdaptedDataset with a function to munge operations to best fit the needs of the Adapter. For example, I often want to enforce that a particular operation is applied (e.g. telemetry conversions), but that would show up as the first operation preventing pushing down user operations (like time selections) to the Adapter. This allows me to have special logic about doing time selections before this specific operation.

This seemed like a handy alternative to a generic query optimizer, for now.

@dlindhol

Copy link
Copy Markdown
Member Author

I might not need this as soon as I thought. I'm wanting to make an AdaptedDataset from fdml then add operations so that the time selection are applied first (which that adapter can push down). I figured I would just make a copy of the AdaptedDataset with the compiler, but there is no mechanism to make that copy. (Though I thought that I exposed the AdaptedDataset's Adapter somewhere?)

@dlindhol dlindhol marked this pull request as draft January 26, 2026 15:32

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using this experimentally for I-ALiRT so I can add operations to manipulate the dataset yet still be able to push down time selections to the wrapped dataset's adapter that builds the service query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant