Conversation
Member
Author
|
I might not need this as soon as I thought. I'm wanting to make an AdaptedDataset from fdml then add operations so that the time selection are applied first (which that adapter can push down). I figured I would just make a copy of the AdaptedDataset with the compiler, but there is no mechanism to make that copy. (Though I thought that I exposed the AdaptedDataset's Adapter somewhere?) |
dlindhol
commented
Jan 26, 2026
Member
Author
There was a problem hiding this comment.
I am using this experimentally for I-ALiRT so I can add operations to manipulate the dataset yet still be able to push down time selections to the wrapped dataset's adapter that builds the service query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like a simple yet powerful way to construct an AdaptedDataset with a function to munge operations to best fit the needs of the Adapter. For example, I often want to enforce that a particular operation is applied (e.g. telemetry conversions), but that would show up as the first operation preventing pushing down user operations (like time selections) to the Adapter. This allows me to have special logic about doing time selections before this specific operation.
This seemed like a handy alternative to a generic query optimizer, for now.