fix(workers): prevent signal generation progress from clobbering terminal result#3943
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(workers): prevent signal generation progress from clobbering terminal result#3943cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…inal result Late fire-and-forget Redis writes from onStep could complete after the worker wrote the done/error result, leaving the UI stuck polling pending.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a race in agentic signal generation where fire-and-forget Redis progress writes from
onStepcould complete after the worker wrote the terminaldone/errorresult. The UI polls Redis and would stay stuck onpendingeven though generation succeeded.Serializes progress writes and awaits them before returning the terminal result to the caller.
Related issue (if applicable)
N/A — found by automated critical-bug scan.
How was this tested?
createSignalGenerationProgressWritercovering late in-flight writes and post-finalize step suppressionpnpm --filter @app/workers test src/workers/signal-generation-progress.test.tsChecklist