fix(taxonomy): preserve prior scoped tree on persist-phase regeneration failure#4036
Draft
cursor[bot] wants to merge 2 commits into
Draft
fix(taxonomy): preserve prior scoped tree on persist-phase regeneration failure#4036cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…on failure When assignment upsert failed during custom behavior regeneration, the onError compensation deprecated every active scoped cluster — including the prior serving tree — leaving users with an empty tree and failed status. Only deprecate clusters born in the failing pass; continued and untouched prior clusters stay active. Co-authored-by: Gerard <gerard@latitude.so>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Co-authored-by: Gerard <gerard@latitude.so>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a data-loss bug in custom behavior taxonomy regeneration (#4027). When the persist phase failed after materializing new clusters but before assignment upsert completed, the
onErrorcompensation calleddeprecateCustomBehaviorTreeUseCase, which deprecated every active scoped cluster — including the prior serving tree.The fix deprecates only clusters born in the failing pass, leaving continued and untouched prior clusters active.
Related issue (if applicable)
N/A — found by automated bug scan.
How was this tested?
activewhen assignment upsert fails on regeneration with a topic change.pnpm --filter @domain/taxonomy test -- build-custom-behavior-taxonomy.test.ts(98 tests pass).Checklist