Conversation
maddyscientist
left a comment
maddyscientist
left a comment
There was a problem hiding this comment.
Looks mostly good.
- How about a unit test for this?
- Will need a clang format
- Also see my inline comments
…ature/gauge_shift Conflicts: lib/cpu_gauge_field.cpp lib/gauge_shift.cu
| * @param[in] srd Source from which we are shifting (extended field in case of MPI) | ||
| * @param[in] dx Host array of shifts to apply to the field | ||
| */ | ||
| void gaugeShift(GaugeField &dst, const GaugeField &src, const array<int, 4> &dx); |
There was a problem hiding this comment.
Should this be moved to e.g. gauge_tools.h?
There was a problem hiding this comment.
Yeah, that seems like a consistent place for it.
|
@maddyscientist thank you for the review. I applied the suggested changes and run clang format via Only the unit testing would be missing. Could you please point me to one of the current tests to extend / base it on? |
Looks good I think.
I guess the easiest one to hack from as a base is The bigger question is what the test would consist of. Some ideas, OTOH:
Anything else come to mind? |
2 participants
This is a (partial) implementation of shifting for gauge field. The CPU kernel is missing, but in light of the unification of cpuGaugeField and cudaGaugeField, I would avoid implementing it.