build: move bash commands in scripts to shx #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 112f534 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
frolic
commented
Aug 28, 2024
| "clean": "turbo run clean", | ||
| "dev": "TSUP_SKIP_DTS=true turbo run dev --concurrency 100 --filter=!@latticexyz/explorer", | ||
| "dist-tag-rm": "pnpm recursive exec -- sh -c 'npm dist-tag rm $(cat package.json | jq -r \".name\") $TAG || true'", | ||
| "docs:generate:api": "bun scripts/render-api-docs.ts", | ||
| "docs:generate:api": "tsx scripts/render-api-docs.ts", |
There was a problem hiding this comment.
bun, or at least this version, doesn't run on windows, and we're only using it in these two spots, so figured we could standardize on tsx like everywhere else until we're ready to actually transition over to bun
karooolis
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out of #3078
we use shell commands like
cp,touch,rm, andmkdirin scripts, but only hadrimrafandmkdirpas options for windows-safe versions of these commandsshx seems to be a more complete offering of shell commands via node