Skip to content

Conversation

@vdrg
Copy link
Contributor

@vdrg vdrg commented Oct 28, 2024

Fixes #2824

Had to also update the getStoreLogs test snapshot because the system's address changed for some reason. My current theory is that the compiler is just acting weird because of the new forge-std version (when compiling everything the bytecode of the system changes). Haven't been able to fully isolate the issue tho, but probably not really important?

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: fea1c85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/cli Patch
@latticexyz/gas-report Patch
@latticexyz/schema-type Patch
@latticexyz/store Patch
@latticexyz/world-module-callwithsignature Patch
@latticexyz/world-module-erc20 Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
create-mud Patch
@latticexyz/world-consumer Patch
@latticexyz/common Patch
@latticexyz/config Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/stash Patch
@latticexyz/store-sync Patch
@latticexyz/entrykit Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/block-logs-stream Patch
@latticexyz/faucet Patch
@latticexyz/abi-ts Patch
@latticexyz/paymaster Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch
vite-plugin-mud Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frolic
Copy link
Member

frolic commented Oct 30, 2024

given that the gas reports also changed, I suspect this caused a small bytecode change, prob the compiler taking a new path (even though we're not importing forge-std anywhere except in tests/scripts)

@vercel
Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
id.place ❌ Failed (Inspect) Jul 16, 2025 3:41pm

@frolic frolic merged commit b803eb1 into main Jul 16, 2025
18 of 19 checks passed
@frolic frolic deleted the vdrg/update-forge-std branch July 16, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bump foundry-std

3 participants