Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support systems without System suffix #3649

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: support systems without System suffix #3649

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c43567
Support systems without suffix by adding them to MUD config
vdrg Apr 1, 2025
31ae7d6
Create small-horses-own.md
vdrg Apr 1, 2025
ab0ad91
Use system labels from namespaces config
vdrg Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/small-horses-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@latticexyz/world": patch
---

Support systems without the System suffix by adding them to the MUD config.
14 changes: 13 additions & 1 deletion packages/world/ts/node/getSystemContracts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,22 @@ export async function getSystemContracts({
pattern: path.join(config.sourceDirectory, "**"),
});

// Get systems from the top-level systems object
const topLevelSystems = Object.keys(config.systems);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this! the top level config is also mirrored to the namespaces config (the default entry point for tooling)


// Get systems from namespaces
const namespaceSystems = Object.values(config.namespaces || {}).flatMap((namespace) =>
Object.keys(namespace.systems || {}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we map these to namespace.label rather than key to keep tooling consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I'm doing: Object.values(namespace.systems).map((system) => system.label),, let me know if that is what you meant

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, the namespaces flatMap is the "standard" path for this kinda thing

);

// Combine both sets of systems
const configSystems = [...topLevelSystems, ...namespaceSystems];

return solidityFiles
.filter(
(file) =>
file.basename.endsWith("System") &&
// Include files with the System suffix and files defined in config
(file.basename.endsWith("System") || configSystems.includes(file.basename)) &&
// exclude the base System contract
file.basename !== "System" &&
// exclude interfaces
Expand Down
Loading