Skip to content

fix(explorer): read system functions - #3783

Merged
karooolis merged 4 commits into
mainfrom
kumpis/system-fn-reads
Jul 10, 2025
Merged

fix(explorer): read system functions#3783
karooolis merged 4 commits into
mainfrom
kumpis/system-fn-reads

Conversation

@karooolis

Copy link
Copy Markdown
Contributor

No description provided.

@karooolis
karooolis requested a review from alvrs as a code owner July 8, 2025 15:22
@changeset-bot

changeset-bot Bot commented Jul 8, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7ac9a0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/explorer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/entrykit Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/paymaster Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
vite-plugin-mud Patch
@latticexyz/world-consumer Patch
@latticexyz/world-module-callwithsignature Patch
@latticexyz/world-module-erc20 Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread .changeset/nice-wombats-destroy.md Outdated
to: worldAddress as Address,
});
result = data;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not blocking) I noticed lots of duplicate logic between the read/write case and system ID/not case, would be nice to clean that up in the future

frolic
frolic previously approved these changes Jul 10, 2025
Co-authored-by: Kevin Ingersoll <kingersoll@gmail.com>
@karooolis
karooolis merged commit c4447b1 into main Jul 10, 2025
17 checks passed
@karooolis
karooolis deleted the kumpis/system-fn-reads branch July 10, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants