Skip to content

fix(explorer): handle invalid system abis #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karooolis merged 3 commits into from
Jul 11, 2025
+15 −4
Merged

fix(explorer): handle invalid system abis #3786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
333f939
try/catch system abis
karooolis Jul 11, 2025
9ec25a4
return empty abi for faulty abi
karooolis Jul 11, 2025
748fd17
Create soft-bats-jump.md
karooolis Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-bats-jump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@latticexyz/store-sync": patch
---

Invalid registered system ABIs are now handled by displaying an empty ABI.
14 changes: 10 additions & 4 deletions packages/store-sync/src/world/getSystemAbis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Client, Abi, Address, Hex, hexToString, parseAbi, stringToHex, toFuncti
import metadataConfig from "@latticexyz/world-module-metadata/mud.config";
import { getRecords } from "../getRecords";
import { getFunctions } from "./getFunctions";
import { groupBy } from "@latticexyz/common/utils";
import { groupBy, isNotNull } from "@latticexyz/common/utils";
import { functionSignatureToAbiItem } from "./functionSignatureToAbiItem";
import { hexToResource } from "@latticexyz/common";
import { isAbiFunction } from "./common";
Expand Down Expand Up @@ -52,9 +52,15 @@ export async function getSystemAbis({
return isAbiTag && matchesSystemId;
})
.map(({ resource, value }) => {
const abi = value === "0x" ? [] : parseAbi(hexToString(value).split("\n"));
return [resource, abi] as const;
}),
try {
const abi = value === "0x" ? [] : parseAbi(hexToString(value).split("\n"));
return [resource, abi] as const;
} catch (error) {
console.error("error parsing system abi", error);
return [resource, []] as const;
}
})
.filter(isNotNull),
);

const systemFunctions = Object.fromEntries(
Expand Down
Loading