feat(cli): output chain ID at start of deploy - #3822
Closed
SSDWGG wants to merge 2 commits into
Closed
Conversation
Print the chain ID alongside the deployer address so users can verify they are deploying to the intended chain before the deployment completes. Fixes #3568
|
|
@SSDWGG is attempting to deploy a commit to the Lattice Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3568 — adds the chain ID to the deploy output so users can verify they are deploying to the intended chain before the deployment completes.
Change
packages/cli/src/runDeploy.ts:Why
Previously, the chain ID was only visible after deployment completed (written to the deploys file). When switching between chains during testing, users had no way to confirm which chain they were targeting until the deploy finished.
Type of Change