-
Notifications
You must be signed in to change notification settings - Fork 21
Upload LiveCodeBench Pro Log #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @rese1f, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request integrates LiveCodeBench Pro, a platform for competitive programming problems, into the Terminal-Bench execution framework. The changes provide a robust adapter that converts LiveCodeBench Pro tasks into a format compatible with Terminal-Bench, allowing for automated evaluation of coding agents. The inclusion of detailed logs and results for several tasks serves as concrete examples and validation of the adapter's functionality, ensuring a smooth setup for future evaluations.
Highlights
- LiveCodeBench Pro Adapter Integration: Introduced a new adapter for LiveCodeBench Pro, enabling standardized evaluation of coding agents on competitive programming tasks within the Terminal-Bench framework.
- Comprehensive Documentation: Added a detailed README.md for the LiveCodeBench Pro adapter, outlining its structure, task format, key files, usage instructions, and external judge integration.
- Inclusion of Task Logs and Results: Uploaded a collection of successful LiveCodeBench Pro task runs, including command logs, terminal pane outputs, detailed JSON results, and session recordings, demonstrating successful external judge validation for various problems.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a comprehensive set of test logs and results for the new livecodebenchpro adapter. The changes include a README file detailing the structure and numerous log files for various test cases. My review focuses on adherence to the repository's style guide. I've found one high-severity issue related to missing tb.lock files, which are required by the style guide.
| │ ├── results.json # Aggregated oracle results | ||
| │ ├── run_metadata.json # Execution metadata | ||
| │ ├── oracle.png # Terminal Screenshot | ||
| │ └── tb.lock # Terminal-bench lock file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style guide requires tb.lock files to be uploaded with the test logs.1 While the directory structure in this README correctly includes tb.lock, the file itself is missing from all the oracle/lcbpro-*/ directories added in this pull request. Please add the required tb.lock files to comply with the repository's contribution guidelines.
No description provided.