add option to generate certificates from a third-party CA #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin11-allen-nttd
changed the title
chris11-taylor-nttd
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
Removes the option to deploy a private DNS zone with the key vault. The private DNS zone is better deployed with a vnet, in case multiple key vaults are being created on the same network. The vnet module currently allows for this.
Users can now specify the IDs of existing private DNS zones to link the private endpoint to, or leave it blank in case Azure Policy is configured to link the private endpoints to a centralized DNS zone automatically
Updated the major version of the naming module, which will cause issues for any existing deployments that abbreviate the region name but are not being deployed to a US region
Features
Added option to generate certificates, either self-signed or with an integrated third-party CA like DigiCert
Fixes
Reverts changes to the
private_vaultexample which caused it to deploy a public vaultFixes secrets and certificates not able to be created when using RBAC instead of access policies
var.role_assignmentsfor the current user