Merged
Conversation
keelerm84
approved these changes
Oct 13, 2025
| env: | ||
| BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} | ||
| OPENSSL_ROOT_DIR: ${{ steps.install-openssl.outputs.OPENSSL_ROOT_DIR }} | ||
| Boost_DIR: 'C:\local\boost_1_87_0\lib64-msvc-14.3\cmake\Boost-1.87.0' |
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
On those platforms it is automatically discovered.
| GIT_TAG ccad7ebaf99310957004661d1c5f82d2a33ebd10 | ||
| GIT_SHALLOW TRUE | ||
| SOURCE_DIR _deps/hiredis | ||
| SOURCE_DIR ${CMAKE_BINARY_DIR}/_deps/hiredis |
There was a problem hiding this comment.
Bug: CMake Path Mismatch Causes Compilation Failures
The hiredis SOURCE_DIR was updated to use CMAKE_BINARY_DIR, but the include_directories path still references CMAKE_CURRENT_BINARY_DIR. This creates a path mismatch for hiredis headers when this CMake file is included from a subdirectory, potentially leading to compilation failures.
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Oct 13, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-server-redis-source: 2.2.0</summary> ## [2.2.0](launchdarkly-cpp-server-redis-source-v2.1.20...launchdarkly-cpp-server-redis-source-v2.2.0) (2025-10-13) ### Features * Update to hiredis 1.3 ([#485](#485)) ([3315e6d](3315e6d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release libs/server-sdk-redis-source 2.2.0, including an update to hiredis 1.3. > > - **Release: `libs/server-sdk-redis-source` 2.2.0** > - Version bumps in `CMakeLists.txt`, `package.json`, and `.release-please-manifest.json`. > - **Feature**: Update dependency to hiredis 1.3 (`CHANGELOG.md`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit b9434f4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake removed support for projects targeting CMake 3.5, hiredis 1.3 moved to CMake 3.7. Both are less than our required version.
This also updates redis-plus-plus which is a C++ wrapper around hiredis.
Note
Upgrades Redis dependencies (hiredis 1.3, newer redis-plus-plus), switches to new redis++ include path, updates CI to Boost 1.87 using Boost_DIR, and suppresses AppleClang deprecated-builtin warnings.
cmake/redis-plus-plus.cmaketo hiredis1.3.0and a newerredis-plus-pluscommit; adjustSOURCE_DIRfor hiredis.-Wno-deprecated-builtinsfor Clang/AppleClang inCMakeLists.txt.#include <redis++.h>with#include <sw/redis++/redis++.h>across Redis source/tests.Boost_DIR; addBoost_DIRenv to composite CI and Windows release step.cmake-tests/README.mdnow documentsBoost_DIRinstead ofBOOST_ROOT.vendor/foxy/cmake/certify.cmaketo a newer commit.Written by Cursor Bugbot for commit 1b2488c. This will update automatically on new commits. Configure here.