Skip to content

refactor: add Apply method to MemoryStore for transactional change sets#515

Merged
beekld merged 6 commits intomainfrom
beeklimt/SDK-2095
Mar 31, 2026
Merged

refactor: add Apply method to MemoryStore for transactional change sets#515
beekld merged 6 commits intomainfrom
beeklimt/SDK-2095

Conversation

@beekld
Copy link
Copy Markdown
Contributor

@beekld beekld commented Mar 30, 2026

This is a simple PR to add an equivalent of Java's InMemoryStore#apply. Unit tests are added. I don't predict anything controversial here.


Note

Medium Risk
Introduces new mutation path that can clear and repopulate the in-memory flag/segment cache, so incorrect change-set composition or missed object types could cause stale or missing data. Scope is limited to MemoryStore and is covered by focused unit tests.

Overview
Adds MemoryStore::Apply(FDv2ChangeSet) to apply FDv2 transactional updates: no-op for kNone, merge for kPartial, and clear + reinitialize for kFull (also setting initialized_).

Includes a new memory_store_apply_test.cpp test suite validating initialization behavior, full-replace semantics, and partial update/preservation for flags and segments.

Written by Cursor Bugbot for commit 7826357. This will update automatically on new commits. Configure here.

@beekld beekld requested a review from a team as a code owner March 30, 2026 23:44
@beekld beekld merged commit 6f795b2 into main Mar 31, 2026
46 checks passed
@beekld beekld deleted the beeklimt/SDK-2095 branch March 31, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants