refactor: add Apply method to MemoryStore for transactional change sets#515
Merged
refactor: add Apply method to MemoryStore for transactional change sets#515
Conversation
kinyoklion
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple PR to add an equivalent of Java's
InMemoryStore#apply. Unit tests are added. I don't predict anything controversial here.Note
Medium Risk
Introduces new mutation path that can clear and repopulate the in-memory flag/segment cache, so incorrect change-set composition or missed object types could cause stale or missing data. Scope is limited to
MemoryStoreand is covered by focused unit tests.Overview
Adds
MemoryStore::Apply(FDv2ChangeSet)to apply FDv2 transactional updates: no-op forkNone, merge forkPartial, and clear + reinitialize forkFull(also settinginitialized_).Includes a new
memory_store_apply_test.cpptest suite validating initialization behavior, full-replace semantics, and partial update/preservation for flags and segments.Written by Cursor Bugbot for commit 7826357. This will update automatically on new commits. Configure here.