chore: add explicit permissions to release-please workflow#57
Draft
kinyoklion wants to merge 1 commit intomainfrom
Draft
chore: add explicit permissions to release-please workflow#57kinyoklion wants to merge 1 commit intomainfrom
kinyoklion wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit
contents: writeandpull-requests: writepermissions to therelease-pleasejob. Without these, the job relies on inherited defaultGITHUB_TOKENpermissions, which may be insufficient if the org or repo defaults are tightened to read-only.These permissions are required for release-please to:
pull-requests: write)contents: write)Downstream jobs (
release-sdk-internal,release-sdk-internal-provenance) already have their own explicitpermissionsblocks and are unaffected.This was identified during an audit of all non-archived
launchdarkly-sdk-tagged repositories.Review & Testing Checklist for Human
permissionsblock restricts the token to only the listed permissions (plusmetadata: read). Confirm thatrelease-please-actionin this repo does not require anything beyondcontents: writeandpull-requests: write(e.g.,issues: writefor label management).release-pleaseworkflow run (triggered by a push tomain) to confirm it still creates/updates release PRs successfully.Notes
This is part of a batch fix across
launchdarkly-sdk-tagged repositories whose release-please workflows were missing explicit permissions on their default branch.Link to Devin session: https://app.devin.ai/sessions/a83b6e4f4fa14b96b859cfb50755a2c1
Requested by: @kinyoklion