feat: Add support for WASM. #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Apr 15, 2025
| http_parser: ^4.0.0 | ||
| uuid: ">= 3.0.7 <5.0.0" | ||
| crypto: ^3.0.3 | ||
| web: ^1.1.1 |
kinyoklion
commented
Apr 15, 2025
There was a problem hiding this comment.
This file was regenerated.
kinyoklion
commented
Apr 15, 2025
| final messageEvent = event as web.MessageEvent; | ||
| final ldMessageEvent = ld_message_event.MessageEvent( | ||
| messageEvent.type, messageEvent.data, messageEvent.lastEventId); | ||
| messageEvent.type, (messageEvent.data as JSString).toDart, messageEvent.lastEventId); |
There was a problem hiding this comment.
This cast should be done safer.
| final ldMessageEvent = ld_message_event.MessageEvent(messageEvent.type, | ||
| (messageEvent.data as JSString).toDart, messageEvent.lastEventId); | ||
| _messageEventsController.sink.add(ldMessageEvent); | ||
| } |
There was a problem hiding this comment.
@kinyoklion This is my attempt to make this cast safer. ld_message_event.MessageEvent will not accept null for the data parameter so my thought is that if we can't cast it then we just skip handling the message. Thoughts?
There was a problem hiding this comment.
That sounds reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.