chore: add explicit permissions to release-please workflow#21
Merged
kinyoklion merged 1 commit intomasterfrom Mar 25, 2026
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
joker23
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
No test changes needed — this is a CI workflow permissions fix only.
Related issues
N/A
Describe the solution you've provided
Adds explicit
contents: writeandpull-requests: writepermissions to therelease-pleasejob. Without these, the job relies on the repository's defaultGITHUB_TOKENpermissions, which may not include write access for contents and pull requests if the repository or organization defaults have been tightened.These permissions are required for release-please to:
pull-requests: write)contents: write)Describe alternatives you've considered
Setting broader permissions at the workflow level (
permissions:at the top level), but scoping permissions to the specific job is more secure and follows the principle of least privilege.Additional context
This is part of an audit of all
launchdarkly-sdk-tagged repositories to ensure release-please workflows have the necessary explicit permissions.Human review checklist
Link to Devin session: https://app.devin.ai/sessions/a83b6e4f4fa14b96b859cfb50755a2c1
Requested by: @kinyoklion
Note
Low Risk
Low risk CI-only change that tightens and clarifies required
GITHUB_TOKENscopes; main impact is enabling or restricting release automation if mis-scoped.Overview
Updates
.github/workflows/release-please.ymlto explicitly grant therelease-pleasejobcontents: writeandpull-requests: writepermissions.This avoids relying on repository/org default
GITHUB_TOKENpermissions and ensures release-please can create/update release PRs and publish tags/releases.Written by Cursor Bugbot for commit aa98c4f. This will update automatically on new commits. Configure here.