Conversation
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Devin check test failures. |
|
The only test failure is "Linux, Go 1.17 / Unit Tests and Coverage" — this fails during the golangci-lint v2.11.1 requires Go 1.22+ to run (it uses Note that:
This is a pre-existing CI config issue — the lint step runs on all Go versions in the matrix, but golangci-lint v2 doesn't support Go 1.17. The fix would be to either skip linting on Go 1.17 in the CI workflow or remove Go 1.17 from the matrix. Neither is in scope for this version bump PR. |
Summary
Bumps
golangci-lintfrom v1.60.1 to v2.11.1 in the Makefile and fixes twostaticcheckissues surfaced by the new version:parse.go: RenamedinvalidSemverError→errInvalidSemverto follow Go error naming convention (ST1012). The variable is unexported, so there is no API change.scan.go: Simplifiedvar ch uint8 = s.source[s.pos]toch := s.source[s.pos]since the type is inferred from the right-hand side (ST1023).stringindexing returnsbyte(uint8), so behavior is identical.Part of a broader effort to bump golangci-lint across LaunchDarkly Go repositories, matching ld-relay#586.
Review & Testing Checklist for Human
.golangci.ymlthat needs v1→v2 migration, or that any existing config is already v2-compatibleerrInvalidSemverrename doesn't break any test assertions that match on the variable name (rather than the error string)Notes
Link to Devin session: https://app.devin.ai/sessions/45faa2d1c22c41c6beab7ce8e891bc96
Requested by: @keelerm84
Note
Low Risk
Primarily tooling/version bumps plus minor refactors; main risk is compatibility for users/builds still on Go <1.22.
Overview
Updates the repository’s minimum supported Go version to
1.22(includinggo.mod’sgodirective and CI version variables).Bumps
golangci-lintfromv1.60.1tov2.11.1and applies small lint-driven refactors (renameinvalidSemverErrortoerrInvalidSemver, simplify a byte assignment inscan.go) with no intended behavior change.Written by Cursor Bugbot for commit ccc0f4d. This will update automatically on new commits. Configure here.