-
Notifications
You must be signed in to change notification settings - Fork 2
Use OctoSTS for raising PRs; upgrade actions; run zizmor #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4288d04
cdc3973
28c4480
34a5439
b0185c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| issuer: https://token.actions.githubusercontent.com | ||
| subject_pattern: repo:launchdarkly/go-semver:ref:refs/heads/main | ||
| claim_pattern: | ||
| event_name: workflow_dispatch|schedule | ||
| ref: refs/heads/main | ||
| ref_protected: "true" | ||
| workflow_ref: launchdarkly/go-semver/.github/workflows/check-go-versions.yml@refs/heads/main | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull_requests: write |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,11 +6,17 @@ on: | |
| - main | ||
| workflow_dispatch: | ||
|
|
||
|
|
||
| permissions: | ||
| contents: write | ||
| issues: write | ||
| pull-requests: write | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary workflow-level permission overridden by job-level permissionsLow Severity The newly added workflow-level
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is likely because we added the job level permissions to main between the opening of this PR and now, so this is redundant now. I do generally agree that job level permissions are better than workflow level permissions. Especially being as some jobs execute in repo code and other jobs do not. |
||
|
|
||
| jobs: | ||
| release-please: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-slim | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| steps: | ||
| - uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4 | ||
| - uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4.4.0 | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to pin all the SHAs, and include a comment of the specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't pinned these since we don't enforce pinning actions from GitHub's official
actionsorg. I'm happy to pin absolutely everything though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been pinning basically everything, but if our general guidance is going to not be pinning official actions, then I could see that.