Skip to content

ci(contract-test-utils): consolidating test websocket implementation#1193

Open
joker23 wants to merge 8 commits intomainfrom
skz/sdk-2010/contract-test-share
Open

ci(contract-test-utils): consolidating test websocket implementation#1193
joker23 wants to merge 8 commits intomainfrom
skz/sdk-2010/contract-test-share

Conversation

@joker23
Copy link
Copy Markdown
Contributor

@joker23 joker23 commented Mar 17, 2026

Note

Medium Risk
Moderate risk because it refactors shared contract-test infrastructure (WebSocket command routing and SDK config construction) used by multiple entity implementations, so regressions could break test harness interactions across platforms.

Overview
Consolidates client-side contract test entity plumbing into @launchdarkly/js-contract-test-utils by adding shared TestHarnessWebSocketBuilder, ClientEntity, doCommand dispatch, and a reusable ConfigBuilder for translating harness config into SDK options.

Updates the browser, React, and React Native contract-test entities to use the shared builder/entity/config utilities, removing their bespoke WebSocket servers and per-SDK command/config duplication while preserving existing capability declarations and initialization semantics (timeouts/initCanFail).

Written by Cursor Bugbot for commit 6e46f7f. This will update automatically on new commits. Configure here.


Open with Devin

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179146 bytes
Compressed size limit: 200000
Uncompressed size: 828569 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 36775 bytes
Compressed size limit: 38000
Uncompressed size: 201898 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31371 bytes
Compressed size limit: 34000
Uncompressed size: 111380 bytes

@joker23 joker23 force-pushed the skz/sdk-2010/contract-test-share branch from 03c4541 to 47e104b Compare March 18, 2026 18:54
@joker23
Copy link
Copy Markdown
Contributor Author

joker23 commented Mar 18, 2026

@cursor review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@joker23 joker23 marked this pull request as ready for review March 18, 2026 20:48
@joker23 joker23 requested a review from a team as a code owner March 18, 2026 20:48
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@joker23 joker23 force-pushed the skz/sdk-2010/contract-test-share branch from 47e104b to 85c21bc Compare March 20, 2026 21:46
@joker23 joker23 marked this pull request as draft March 24, 2026 21:02
@joker23 joker23 marked this pull request as draft March 24, 2026 21:02
@joker23
Copy link
Copy Markdown
Contributor Author

joker23 commented Mar 24, 2026

moving this back to draft because the test adapter consolidation is more impactful and would likely change what we are doing here

@joker23 joker23 force-pushed the skz/sdk-2010/contract-test-share branch from 85c21bc to 2aa8dc5 Compare March 26, 2026 20:46
@joker23 joker23 force-pushed the skz/sdk-2010/contract-test-share branch from e1b006e to 206d682 Compare March 26, 2026 23:37
@joker23 joker23 force-pushed the skz/sdk-2010/contract-test-share branch from 5b56bba to 6730462 Compare March 27, 2026 00:21
PR was getting too big
@joker23 joker23 marked this pull request as ready for review March 27, 2026 00:27
devin-ai-integration[bot]

This comment was marked as resolved.

cursor[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

cursor[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant