Skip to content

chore: adding script for initial npm publish#1216

Merged
joker23 merged 4 commits intomainfrom
skz/sdk-1737/oidc-initial-publish
Mar 24, 2026
Merged

chore: adding script for initial npm publish#1216
joker23 merged 4 commits intomainfrom
skz/sdk-1737/oidc-initial-publish

Conversation

@joker23
Copy link
Copy Markdown
Contributor

@joker23 joker23 commented Mar 23, 2026

Creating a more scripted flow for initial package publishing to set up npm OIDC


Note

Low Risk
Low risk documentation and tooling change; the new script can publish to npm and relies on user credentials, but it is an explicit manual step with safeguards to skip existing packages.

Overview
Streamlines initial npm package bootstrapping for OIDC trusted publishing by replacing the manual placeholder publish steps in contributing/publishing.md with a single ./scripts/publish-placeholder-package.sh command and repo-specific trusted-publisher values.

Adds publish-placeholder-package.sh, which derives the package name from a workspace path, checks npm to avoid publishing if the package already exists, and publishes an empty 0.0.0 placeholder under the snapshot tag while handling npm login/npm logout and cleanup automatically.

Written by Cursor Bugbot for commit 488370a. This will update automatically on new commits. Configure here.


Open with Devin

@joker23 joker23 requested a review from a team as a code owner March 23, 2026 20:34
@joker23 joker23 marked this pull request as draft March 23, 2026 20:35
@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 25042 bytes
Compressed size limit: 34000
Uncompressed size: 87384 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 172878 bytes
Compressed size limit: 200000
Uncompressed size: 804511 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 29404 bytes
Compressed size limit: 38000
Uncompressed size: 158016 bytes

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@joker23
Copy link
Copy Markdown
Contributor Author

joker23 commented Mar 23, 2026

@cursor review

cursor[bot]

This comment was marked as resolved.

@joker23
Copy link
Copy Markdown
Contributor Author

joker23 commented Mar 23, 2026

@cursor review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@joker23 joker23 marked this pull request as ready for review March 24, 2026 14:49
to configure trusted publishing on the new NPM package, then mark the package public.

After everything is set up, you can then mark the package public.
> HINT: you will need to enable the `release-please.yml` workflow for
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It this really a hint?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make it more obvious 👍

@joker23 joker23 merged commit 10d33d2 into main Mar 24, 2026
43 checks passed
@joker23 joker23 deleted the skz/sdk-1737/oidc-initial-publish branch March 24, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants