Skip to content

ci: add explicit permissions to release-please job#1224

Merged
joker23 merged 1 commit intomainfrom
devin/1774458164-fix-release-please-permissions
Mar 25, 2026
Merged

ci: add explicit permissions to release-please job#1224
joker23 merged 1 commit intomainfrom
devin/1774458164-fix-release-please-permissions

Conversation

@joker23
Copy link
Copy Markdown
Contributor

@joker23 joker23 commented Mar 25, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

N/A — CI-only change, no application code or tests affected.

Related issues

Describe the solution you've provided

The release-please job in the release-please.yml workflow was failing because its GITHUB_TOKEN only had Contents: read permission. The job needs contents: write to create git trees/commits and pull-requests: write to update the release PR branch via the GitHub API.

The previous successful run (Mar 24) had full write permissions via the repo/org default, but a subsequent change to the default workflow permissions reduced the token to read-only, breaking this job. Other jobs in the same workflow (e.g., release-common) were unaffected because they already declare explicit permissions.

This PR adds an explicit permissions block to the release-please job, matching the pattern used by the other release jobs.

Describe alternatives you've considered

Reverting the repository/organization default workflow permissions back to "Read and write" — rejected because explicit per-job permissions follow the principle of least privilege and are more resilient to future settings changes.

Additional context

Human review checklist

  • Confirm that contents: write + pull-requests: write are sufficient for release-please-action@v4 (the action docs list these as the required permissions)
  • Verify whether the repo/org default workflow permissions change was intentional — if so, other workflows without explicit permissions may also need updating

Link to Devin session: https://app.devin.ai/sessions/cb7dde700084447b9b8c4e3e95de65b4
Requested by: @joker23


Note

Medium Risk
Adds contents: write and pull-requests: write to the release-please workflow job, slightly increasing CI token privileges but scoped to the release automation path.

Overview
Fixes failing automated releases by adding an explicit permissions block to the release-please job in .github/workflows/release-please.yml, granting GITHUB_TOKEN contents: write and pull-requests: write so release-please-action can create commits/trees and update the release PR.

Written by Cursor Bugbot for commit 676b99d. This will update automatically on new commits. Configure here.


Open with Devin

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot added the devin-pr PRs created by Devin AI label Mar 25, 2026
@devin-ai-integration
Copy link
Copy Markdown
Contributor

@cursor review

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 172878 bytes
Compressed size limit: 200000
Uncompressed size: 804511 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 25042 bytes
Compressed size limit: 34000
Uncompressed size: 87384 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 29404 bytes
Compressed size limit: 38000
Uncompressed size: 158016 bytes

@joker23 joker23 marked this pull request as ready for review March 25, 2026 17:21
@joker23 joker23 requested a review from a team as a code owner March 25, 2026 17:21
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@joker23 joker23 merged commit 669cc0c into main Mar 25, 2026
44 checks passed
@joker23 joker23 deleted the devin/1774458164-fix-release-please-permissions branch March 25, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PRs created by Devin AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants