refactor(react-sdk): renamed example server-only react-server-example#1237
refactor(react-sdk): renamed example server-only react-server-example#1237
server-only react-server-example#1237Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@cursor review |
38d7499 to
aa7f052
Compare
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "@internal/react-sdk-example-server-only", | |||
| "name": "@internal/react-sdk-example-react-server", | |||
There was a problem hiding this comment.
Directory and package name convention mismatch
Low Severity
The directory is named react-server-example but the package name is @internal/react-sdk-example-react-server, dropping the -example suffix. This breaks the convention established by the hello-react example, where the directory name hello-react maps directly to package name @internal/react-sdk-example-hello-react. Following the same pattern, the package name here would be @internal/react-sdk-example-react-server-example, or alternatively the directory could be renamed to react-server to match the current package name.
aa7f052 to
6f77905
Compare
`react-server-example`
6f77905 to
7336344
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7336344. Configure here.


This PR address the comment on a previous PR (#1218 (comment))
Note
Low Risk
Low risk: this is a rename/reference update across CI, workspace config, and release-please metadata, with only a minor doc comment change in
LDIsomorphicProvider. Main risk is broken paths/job names if any downstream tooling still references the old example name.Overview
Renames the React SDK Next.js RSC example from
server-onlytoreact-server-example, updating the Yarn workspace entry, example package name, and example docs.Updates CI (
react.yml), ESLint ignore patterns, andrelease-please-config.jsonto point at the new example path/workspace, and adds a briefLDIsomorphicProvidercomment linking to the renamed example.Reviewed by Cursor Bugbot for commit 7336344. Bugbot is set up for automated code reviews on this repo. Configure here.