chore: scope all package names to @launchdarkly#1242
Conversation
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk-common size report |
…ames Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
|
@cursor review |
|
@launchdarkly/js-client-sdk size report |
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2d396c8. Configure here.
Requirements
Related issues
N/A
Describe the solution you've provided
Updates 19
package.jsonfiles across the monorepo so that every package name is scoped to@launchdarkly. The affected packages are all examples, playgrounds, and contract test services — none are published SDK packages (those were already correctly scoped).Three categories of renames:
@launchdarkly(14 packages): e.g.akamai-playground→@launchdarkly/akamai-playground@internal→@launchdarkly(4 packages): e.g.@internal/electron-example→@launchdarkly/electron-example@launchdarkly(1 package):feature-flag-apple-store→@launchdarkly/feature-flag-apple-storeAlso updates 8 CI workflow files (
.github/workflows/) and 3 README files that referenced the old workspace names to use the new@launchdarkly-scoped names.Total: 30 files changed (19
package.json+ 8 workflow files + 3 READMEs)Describe alternatives you've considered
N/A — this is a straightforward naming consistency fix.
Additional context
Summary of non-
package.jsonchangesWorkflow files — without these updates,
yarn workspaces focusandyarn workspace <name>commands in CI would fail:browser.yml—browser-contract-test-service→@launchdarkly/browser-contract-test-serviceelectron.yaml—@internal/electron-contract-tests-entity,@internal/electron-example→@launchdarkly/…react.yml—@internal/react-sdk-example-hello-react,@internal/react-sdk-example-server-only→@launchdarkly/…react-nightly.yaml—@internal/react-sdk-example-hello-react→@launchdarkly/…react-native-contract-tests.yml—react-native-contract-test-entity→@launchdarkly/react-native-contract-test-entityreact-native-detox.yml—react-native-example→@launchdarkly/react-native-exampleserver-node.yml—node-server-sdk-contract-tests→@launchdarkly/node-server-sdk-contract-testssvelte.yml—ld-svelte-example→@launchdarkly/ld-svelte-exampleREADME files — updated yarn workspace commands in docs:
packages/sdk/electron/contract-tests/README.mdpackages/sdk/electron/example/README.mdpackages/sdk/server-node/contract-tests/README.mdItems for reviewer attention
yarn installto regenerateyarn.lock. Verify that the lockfile stays consistent after this change.@launchdarkly/-scoped name — no logic changes.Link to Devin session: https://app.devin.ai/sessions/c534d9a8fca44a7480667eaefe8fc7dd
Requested by: @joker23
Note
Medium Risk
Mostly mechanical workspace renames, but it can break CI/local dev if any remaining references to the old package names or yarn workspace commands were missed.
Overview
Scopes all example/playground and contract-test workspace package names to
@launchdarkly/*(including renaming several@internal/*workspaces) by updating theirpackage.jsonnamefields.Updates GitHub Actions workflows and a few READMEs to use the new workspace names in
yarn workspace/yarn workspaces focuscommands so contract tests and example runs continue to resolve the correct workspaces.Reviewed by Cursor Bugbot for commit 2d396c8. Bugbot is set up for automated code reviews on this repo. Configure here.