Skip to content

chore: scope all package names to @launchdarkly#1242

Merged
joker23 merged 4 commits intomainfrom
devin/1775251414-fix-package-scopes
Apr 3, 2026
Merged

chore: scope all package names to @launchdarkly#1242
joker23 merged 4 commits intomainfrom
devin/1775251414-fix-package-scopes

Conversation

@joker23
Copy link
Copy Markdown
Contributor

@joker23 joker23 commented Apr 3, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

N/A

Describe the solution you've provided

Updates 19 package.json files across the monorepo so that every package name is scoped to @launchdarkly. The affected packages are all examples, playgrounds, and contract test services — none are published SDK packages (those were already correctly scoped).

Three categories of renames:

  • Unscoped → @launchdarkly (14 packages): e.g. akamai-playground@launchdarkly/akamai-playground
  • @internal@launchdarkly (4 packages): e.g. @internal/electron-example@launchdarkly/electron-example
  • Misnamed → @launchdarkly (1 package): feature-flag-apple-store@launchdarkly/feature-flag-apple-store

Also updates 8 CI workflow files (.github/workflows/) and 3 README files that referenced the old workspace names to use the new @launchdarkly-scoped names.

Total: 30 files changed (19 package.json + 8 workflow files + 3 READMEs)

Describe alternatives you've considered

N/A — this is a straightforward naming consistency fix.

Additional context

Summary of non-package.json changes

Workflow files — without these updates, yarn workspaces focus and yarn workspace <name> commands in CI would fail:

  • browser.ymlbrowser-contract-test-service@launchdarkly/browser-contract-test-service
  • electron.yaml@internal/electron-contract-tests-entity, @internal/electron-example@launchdarkly/…
  • react.yml@internal/react-sdk-example-hello-react, @internal/react-sdk-example-server-only@launchdarkly/…
  • react-nightly.yaml@internal/react-sdk-example-hello-react@launchdarkly/…
  • react-native-contract-tests.ymlreact-native-contract-test-entity@launchdarkly/react-native-contract-test-entity
  • react-native-detox.ymlreact-native-example@launchdarkly/react-native-example
  • server-node.ymlnode-server-sdk-contract-tests@launchdarkly/node-server-sdk-contract-tests
  • svelte.ymlld-svelte-example@launchdarkly/ld-svelte-example

README files — updated yarn workspace commands in docs:

  • packages/sdk/electron/contract-tests/README.md
  • packages/sdk/electron/example/README.md
  • packages/sdk/server-node/contract-tests/README.md

Items for reviewer attention

  • Yarn lockfile: Renaming workspace packages may require a yarn install to regenerate yarn.lock. Verify that the lockfile stays consistent after this change.
  • Other references: A grep was performed across the repo for old names. Confirm no references were missed in other config files or scripts.
  • All changes are mechanical: Each edit is a direct find-and-replace of the old package name with the new @launchdarkly/-scoped name — no logic changes.

Link to Devin session: https://app.devin.ai/sessions/c534d9a8fca44a7480667eaefe8fc7dd
Requested by: @joker23


Open with Devin

Note

Medium Risk
Mostly mechanical workspace renames, but it can break CI/local dev if any remaining references to the old package names or yarn workspace commands were missed.

Overview
Scopes all example/playground and contract-test workspace package names to @launchdarkly/* (including renaming several @internal/* workspaces) by updating their package.json name fields.

Updates GitHub Actions workflows and a few READMEs to use the new workspace names in yarn workspace/yarn workspaces focus commands so contract tests and example runs continue to resolve the correct workspaces.

Reviewed by Cursor Bugbot for commit 2d396c8. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179331 bytes
Compressed size limit: 200000
Uncompressed size: 829227 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 37015 bytes
Compressed size limit: 38000
Uncompressed size: 202741 bytes

…ames

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

@cursor review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31556 bytes
Compressed size limit: 34000
Uncompressed size: 112044 bytes

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@joker23
Copy link
Copy Markdown
Contributor Author

joker23 commented Apr 3, 2026

@cursor review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 2d396c8. Configure here.

@joker23 joker23 marked this pull request as ready for review April 3, 2026 21:58
@joker23 joker23 requested a review from a team as a code owner April 3, 2026 21:58
@joker23 joker23 merged commit 1039626 into main Apr 3, 2026
44 checks passed
@joker23 joker23 deleted the devin/1775251414-fix-package-scopes branch April 3, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants