-
Notifications
You must be signed in to change notification settings - Fork 37
feat: Add experimental FDv2 support for React Native. #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+250
−63
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6f8f006
feat: React Native FDv2 support.
kinyoklion ca00a4f
Refine RN data system options documents.
kinyoklion 21b3f73
fix: expose setConnectionMode publicly with FDv2 overloads as @internal
kinyoklion eb1a244
PR feedback.
kinyoklion 10ad83a
Lint
kinyoklion cabb3f1
fix: derive isFDv2 from validated config in base class
kinyoklion 3283ecd
fix: use validated dataSystem config for mode switching and clean up …
kinyoklion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,6 +83,7 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult { | |
| private _eventSendingEnabled: boolean = false; | ||
| private _baseHeaders: LDHeaders; | ||
| protected dataManager: DataManager; | ||
| protected readonly isFDv2: boolean; | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is so we don't have to infer from other signal. We just know. |
||
| protected readonly environmentMetadata: LDPluginEnvironmentMetadata; | ||
| private _hookRunner: HookRunner; | ||
| private _inspectorManager: InspectorManager; | ||
|
|
@@ -161,6 +162,7 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult { | |
| this.emitter, | ||
| this._diagnosticsManager, | ||
| ); | ||
| this.isFDv2 = !!this._config.dataSystem; | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Validated data system config, not the input options. |
||
|
|
||
| const hooks: Hook[] = [...this._config.hooks]; | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be strictly required. But if we decide to add RN specific options, then we will have a type to do it in. Where if we use LDClientDataSystemOptions, then we have to do name shenanigans. Or risk breaking things.