docs: clarifying disableCache vs maxCachedContexts#1247
Merged
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
kinyoklion
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to clarify the usage of
disableCacheandmaxCachedContextsin client side sdks.Note
Low Risk
Low risk documentation-only change that clarifies cache configuration semantics without modifying runtime behavior.
Overview
Clarifies the
LDOptionsAPI docs for persistent caching by distinguishingmaxCachedContexts=0(disables caching and prunes existing cached entries) fromdisableCache=true(suppresses cache read/write while leaving existing data intact). Also updates wording to explicitly mention fallback flag values and adds@remarksguidance on when to use each option.Reviewed by Cursor Bugbot for commit 42a5ae6. Bugbot is set up for automated code reviews on this repo. Configure here.