ci(react-native): addressing detox build flakes#1250
Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
joker23
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bd46d35. Configure here.
| // Detox waits for HTTP requests to complete. Blacklist all LD endpoints so | ||
| // streaming, polling, and event requests don't block test synchronization. | ||
| detoxURLBlacklistRegex: | ||
| '\\(".*clientstream.launchdarkly.com.*",".*clientsdk.launchdarkly.com.*",".*events.launchdarkly.com.*"\\)', |
There was a problem hiding this comment.
I am not sure why we would want this for polling/events, when those requests should end.
There was a problem hiding this comment.
The thinking was that those request could potentially time out the launchApp since all of flaky tests all fail due to launchApp so thought it wouldn't hurt to not sync these on start up as there is a timeout on the test when we actually trigger an identify...
That said, this is also probably not actual problem with the test so I don't mind removing this change.
2 participants
This PR will attempt to stablize the react native detox e2e tests in the CI pipelie.
There are 2 changes:
Note
Low Risk
Low risk since changes are limited to CI test invocation and Detox synchronization settings, with no production runtime impact. Main risk is masking legitimate failures or over-broad URL blacklisting causing tests to miss regressions.
Overview
Stabilizes the React Native example Detox Android CI by adding
--retries 2to the Detox test run so transient emulator/test flakes are automatically retried.Updates the e2e app launch args to broaden
detoxURLBlacklistRegexto include LaunchDarkly streaming, SDK, and events endpoints, preventing ongoing network activity from blocking Detox test synchronization.Reviewed by Cursor Bugbot for commit bd46d35. Bugbot is set up for automated code reviews on this repo. Configure here.