chore: Remove unused Payload.id field from FDv2 protocol handler#1260
Open
kinyoklion wants to merge 1 commit intomainfrom
Open
chore: Remove unused Payload.id field from FDv2 protocol handler#1260kinyoklion wants to merge 1 commit intomainfrom
kinyoklion wants to merge 1 commit intomainfrom
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK-2005
Summary
idfield from the internalPayloadinterface and alltempIdplumbing in the protocol handlerPayloadIntent.idbut never read by any downstream consumerPayloadIntent.id,PayloadTransferred.id,ErrorObject.payload_id) are unchangedNote
Low Risk
Low risk refactor that removes an unused field and related plumbing; behavioral changes are limited to slightly different validation/log messages around intent/transfer events.
Overview
Removes the internal FDv2
Payload.idfield and the protocol handler’stempIdtracking, so emitted payloads are keyed only byversion/state/type/updates.Updates SDK client/server components and tests to stop constructing or asserting on
payload.id(including cache initialization, polling/FDv1 fallback payloads, and FDv2 source result helpers), and simplifies protocol-handler warnings/log messages accordingly.Reviewed by Cursor Bugbot for commit a11185e. Bugbot is set up for automated code reviews on this repo. Configure here.