Skip to content

chore: Remove unused Payload.id field from FDv2 protocol handler#1260

Open
kinyoklion wants to merge 1 commit intomainfrom
rlamb/sdk-2005/remove-payload-id
Open

chore: Remove unused Payload.id field from FDv2 protocol handler#1260
kinyoklion wants to merge 1 commit intomainfrom
rlamb/sdk-2005/remove-payload-id

Conversation

@kinyoklion
Copy link
Copy Markdown
Member

@kinyoklion kinyoklion commented Apr 9, 2026

SDK-2005

Summary

  • Removes the id field from the internal Payload interface and all tempId plumbing in the protocol handler
  • The field was populated from PayloadIntent.id but never read by any downstream consumer
  • Wire protocol types (PayloadIntent.id, PayloadTransferred.id, ErrorObject.payload_id) are unchanged

Note

Low Risk
Low risk refactor that removes an unused field and related plumbing; behavioral changes are limited to slightly different validation/log messages around intent/transfer events.

Overview
Removes the internal FDv2 Payload.id field and the protocol handler’s tempId tracking, so emitted payloads are keyed only by version/state/type/updates.

Updates SDK client/server components and tests to stop constructing or asserting on payload.id (including cache initialization, polling/FDv1 fallback payloads, and FDv2 source result helpers), and simplifies protocol-handler warnings/log messages accordingly.

Reviewed by Cursor Bugbot for commit a11185e. Bugbot is set up for automated code reviews on this repo. Configure here.

@kinyoklion kinyoklion changed the title Remove unused Payload.id field from FDv2 protocol handler chore: Remove unused Payload.id field from FDv2 protocol handler Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25623 bytes
Compressed size limit: 29000
Uncompressed size: 125843 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179372 bytes
Compressed size limit: 200000
Uncompressed size: 829982 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31649 bytes
Compressed size limit: 34000
Uncompressed size: 112792 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 37169 bytes
Compressed size limit: 38000
Uncompressed size: 204305 bytes

@kinyoklion kinyoklion marked this pull request as ready for review April 9, 2026 21:37
@kinyoklion kinyoklion requested a review from a team as a code owner April 9, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant