Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): consistent selection display for menus and listbox #1596

Merged
merged 4 commits into from
Mar 28, 2025

Conversation

apucacao
Copy link
Contributor

@apucacao apucacao commented Mar 27, 2025

Summary

Screenshots (if appropriate):

Component Single selection Multiple selection
Menu image image
Listbox image CleanShot 2025-03-27 at 18 41 03

@apucacao apucacao changed the title Ag/feat/consistent selection display feat(components): consistent selection display for menus and listbox Mar 27, 2025
Copy link

pkg-pr-new bot commented Mar 27, 2025

npm i https://pkg.pr.new/@launchpad-ui/components@1596
npm i https://pkg.pr.new/@launchpad-ui/icons@1596
npm i https://pkg.pr.new/@launchpad-ui/tokens@1596

commit: aa16f6a

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Size Change: +19 B (0%)

Total Size: 526 kB

Filename Size Change
packages/components/dist/index.es.js 13 kB +20 B (+0.15%)
packages/components/dist/index.js 13 kB +6 B (+0.05%)
packages/components/dist/style.css 7.38 kB -7 B (-0.09%)
ℹ️ View Unchanged
Filename Size
apps/vscode/dist/client.js 111 kB
apps/vscode/dist/server.js 245 kB
packages/alert/dist/index.es.js 1.32 kB
packages/alert/dist/index.js 1.39 kB
packages/alert/dist/style.css 897 B
packages/avatar/dist/index.es.js 1.16 kB
packages/avatar/dist/index.js 1.23 kB
packages/avatar/dist/style.css 411 B
packages/box/dist/index.es.js 6.87 kB
packages/box/dist/index.js 6.99 kB
packages/box/dist/style.css 2.65 kB
packages/button/dist/index.es.js 1.87 kB
packages/button/dist/index.js 1.94 kB
packages/button/dist/style.css 3 kB
packages/card/dist/index.es.js 678 B
packages/card/dist/index.js 746 B
packages/card/dist/style.css 666 B
packages/chip/dist/index.es.js 674 B
packages/chip/dist/index.js 745 B
packages/chip/dist/style.css 532 B
packages/clipboard/dist/index.es.js 1.49 kB
packages/clipboard/dist/index.js 1.57 kB
packages/clipboard/dist/style.css 750 B
packages/collapsible/dist/index.es.js 856 B
packages/collapsible/dist/index.js 926 B
packages/collapsible/dist/style.css 81 B
packages/columns/dist/index.es.js 579 B
packages/columns/dist/index.js 651 B
packages/columns/dist/style.css 281 B
packages/core/dist/index.es.js 886 B
packages/core/dist/index.js 1.2 kB
packages/drawer/dist/index.es.js 1.7 kB
packages/drawer/dist/index.js 2.25 kB
packages/drawer/dist/style.css 490 B
packages/dropdown/dist/index.es.js 1.19 kB
packages/dropdown/dist/index.js 1.25 kB
packages/filter/dist/index.es.js 2.26 kB
packages/filter/dist/index.js 2.33 kB
packages/filter/dist/style.css 907 B
packages/focus-trap/dist/index.es.js 267 B
packages/focus-trap/dist/index.js 333 B
packages/form/dist/index.es.js 4.1 kB
packages/form/dist/index.js 4.2 kB
packages/form/dist/style.css 2.21 kB
packages/icons/dist/index.es.js 1.27 kB
packages/icons/dist/index.js 1.34 kB
packages/icons/dist/style.css 549 B
packages/inline-edit/dist/index.es.js 1.57 kB
packages/inline-edit/dist/index.js 1.65 kB
packages/inline-edit/dist/style.css 329 B
packages/inline/dist/index.es.js 572 B
packages/inline/dist/index.js 643 B
packages/inline/dist/style.css 243 B
packages/markdown/dist/index.es.js 967 B
packages/markdown/dist/index.js 1.04 kB
packages/markdown/dist/style.css 217 B
packages/menu/dist/index.es.js 3.82 kB
packages/menu/dist/index.js 3.9 kB
packages/menu/dist/style.css 861 B
packages/modal/dist/index.es.js 2.97 kB
packages/modal/dist/index.js 3.54 kB
packages/modal/dist/style.css 892 B
packages/navigation/dist/index.es.js 2.73 kB
packages/navigation/dist/index.js 2.8 kB
packages/navigation/dist/style.css 866 B
packages/overlay/dist/index.es.js 1.03 kB
packages/overlay/dist/index.js 1.09 kB
packages/popover/dist/index.es.js 3.12 kB
packages/popover/dist/index.js 3.62 kB
packages/popover/dist/style.css 523 B
packages/portal/dist/index.es.js 398 B
packages/portal/dist/index.js 457 B
packages/progress-bubbles/dist/index.es.js 1.74 kB
packages/progress-bubbles/dist/index.js 1.81 kB
packages/progress-bubbles/dist/style.css 813 B
packages/progress/dist/index.es.js 1.06 kB
packages/progress/dist/index.js 1.13 kB
packages/progress/dist/style.css 267 B
packages/stack/dist/index.es.js 464 B
packages/stack/dist/index.js 535 B
packages/stack/dist/style.css 181 B
packages/table/dist/index.es.js 931 B
packages/table/dist/index.js 1.01 kB
packages/table/dist/style.css 689 B
packages/tokens/dist/fonts.css 183 B
packages/tokens/dist/index.css 2.35 kB
packages/tokens/dist/index.es.js 2.9 kB
packages/tokens/dist/index.js 2.95 kB
packages/tokens/dist/media-queries.css 113 B
packages/tokens/dist/themes.css 1.12 kB
packages/tooltip/dist/index.es.js 506 B
packages/tooltip/dist/index.js 581 B
packages/tooltip/dist/style.css 326 B
packages/vars/dist/index.es.js 2.41 kB
packages/vars/dist/index.js 2.48 kB

compressed-size-action

Copy link

changeset-bot bot commented Mar 27, 2025

🦋 Changeset detected

Latest commit: aa16f6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@launchpad-ui/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@apucacao apucacao marked this pull request as ready for review March 27, 2025 22:30
@apucacao apucacao requested a review from a team as a code owner March 27, 2025 22:30
@Niznikr Niznikr merged commit 472b85e into main Mar 28, 2025
19 checks passed
@Niznikr Niznikr deleted the ag/feat/consistent-selection-display branch March 28, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants