Skip to content

fix(components): remove extra popover padding for DialogTrigger with menu/listbox #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cpurps22 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix(components): remove extra popover padding for DialogTrigger with menu/listbox #1884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26ecef6
fix(components): remove extra popover padding for DialogTrigger with …
cpurps22 Apr 15, 2026
b0a451f
add changeset for popover padding fix
cpurps22 Apr 15, 2026
d00e544
fix: preserve popover padding for DialogTrigger with search input
cpurps22 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-menu-popover-padding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@launchpad-ui/components': patch
---

Remove extra popover padding when a DialogTrigger popover contains a Menu or ListBox
3 changes: 2 additions & 1 deletion packages/components/src/styles/Popover.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
stroke-width: 1px;
}

&[data-trigger='DialogTrigger'],
&[data-trigger='DialogTrigger']:not(:has([role='menu'], [role='listbox'])),
&[data-trigger='DialogTrigger']:has(input[type='search']),
&[data-trigger='ComboBoxDialog'],
&[data-trigger='DatePicker'],
&[data-trigger='DateRangePicker'] {
Expand Down
Loading