Skip to content

feat: Expose more detail in dev server errors [FUN-701]#522

Merged
mike-zorn merged 2 commits intomainfrom
FUN-701/mrz/merge-customer-pr-error-fidelity
Apr 15, 2025
Merged

feat: Expose more detail in dev server errors [FUN-701]#522
mike-zorn merged 2 commits intomainfrom
FUN-701/mrz/merge-customer-pr-error-fidelity

Conversation

@mike-zorn
Copy link
Copy Markdown

@mike-zorn mike-zorn commented Apr 15, 2025

Expose more details about dev server errors like what thing wasn't found. Requested in #520.


Related Jira issue: FUN-701: Merge customer PR (error fidelity)

This way we know what wasn't found.
@mike-zorn mike-zorn requested a review from Copilot April 15, 2025 17:40
@launchdarkly-upra launchdarkly-upra bot changed the title feat: Expose more detail in dev server errors [FUN-701] feat: Expose more detail in dev server errors Apr 15, 2025
@mike-zorn mike-zorn changed the title [FUN-701] feat: Expose more detail in dev server errors feat: Expose more detail in dev server errors [FUN-701] Apr 15, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances dev server error responses by exposing detailed error messages and refactoring error handling throughout the codebase. Key updates include:

  • Switching from errors.Is to errors.As for more expressive error type handling.
  • Updating error messages to reflect actual error details and replacing legacy error variables with newly defined error types.
  • Adjusting tests to assert errors via errors.As instead of errors.Is.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/dev_server/sdk/store_facade.go Updated WriteError to use errors.As and print the error’s own message.
internal/dev_server/model/sync_test.go Changed test assertions from ErrorIs to ErrorAs for project insertion.
internal/dev_server/model/sync.go Refactored error check for project creation to use errors.As.
internal/dev_server/model/store.go Removed legacy error variable definitions for NotFound and AlreadyExists.
internal/dev_server/model/override_test.go Adjusted tests to assert ErrNotFound errors using errors.As.
internal/dev_server/model/override.go Modified to return NewErrNotFound with detailed error information.
internal/dev_server/model/error.go Removed legacy custom error implementation.
internal/dev_server/model/err_not_found.go Added new error type for not found errors with detailed message formatting.
internal/dev_server/model/err_already_exists.go Added new error type for already exists errors (error message needs update).
internal/dev_server/db/sqlite_test.go Updated tests to verify errors using errors.As.
internal/dev_server/db/sqlite.go Updated error returns to use NewErrNotFound and NewErrAlreadyExists.
internal/dev_server/api/put_override_flag.go Adjusted error check to use errors.As for identifying ErrNotFound.
internal/dev_server/api/post_add_project.go Refactored error handling to use errors.As and return err.Error() message.
internal/dev_server/api/delete_flag_override.go Changed error handling to use errors.As for ErrNotFound errors.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mike-zorn mike-zorn requested a review from a team April 15, 2025 18:02
@mike-zorn mike-zorn merged commit 553525a into main Apr 15, 2025
7 checks passed
@mike-zorn mike-zorn deleted the FUN-701/mrz/merge-customer-pr-error-fidelity branch April 15, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants