Skip to content

fix: OIDC publishing with npm#454

Merged
Vadman97 merged 2 commits intomainfrom
vadim/fix-oidc
Apr 1, 2026
Merged

fix: OIDC publishing with npm#454
Vadman97 merged 2 commits intomainfrom
vadim/fix-oidc

Conversation

@Vadman97
Copy link
Copy Markdown
Contributor

@Vadman97 Vadman97 commented Apr 1, 2026

Summary

npm publish does not correctly package yarn monorepo workspace dependencies.
Update the publishing to use yarn pack to ensure the package is bundled correctly.

Fixes #448

How did you test this change?

publishing from branch

Are there any deployment considerations?


Note

Medium Risk
Changes the npm publishing workflow to publish packed tarballs instead of workspace directories, which can affect what gets shipped to npm and release reliability. Low code complexity, but failures would impact package consumers/releases.

Overview
Fixes npm publishing for Yarn workspaces by switching scripts/publish-npm.sh from npm publish <workspace dir> to yarn pack + npm publish <tarball>, ensuring workspace:* dependencies are resolved to real versions and cleaning up the temp tarball on success/failure.

Also tweaks package descriptions in @launchdarkly/observability and @launchdarkly/session-replay (wording/grammar only).

Written by Cursor Bugbot for commit 2604d9b. This will update automatically on new commits. Configure here.

@Vadman97 Vadman97 requested a review from a team as a code owner April 1, 2026 18:16
@Vadman97 Vadman97 changed the title ci: fix OIDC publishing with npm fix: fix OIDC publishing with npm Apr 1, 2026
@Vadman97 Vadman97 changed the title fix: fix OIDC publishing with npm fix: OIDC publishing with npm Apr 1, 2026
@Vadman97 Vadman97 merged commit ab4221b into main Apr 1, 2026
24 checks passed
@Vadman97 Vadman97 deleted the vadim/fix-oidc branch April 1, 2026 19:10
Vadman97 pushed a commit that referenced this pull request Apr 1, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>observability: 1.1.2</summary>

##
[1.1.2](observability-1.1.1...observability-1.1.2)
(2026-04-01)


### Bug Fixes

* OIDC publishing with npm
([#454](#454))
([ab4221b](ab4221b))
</details>

<details><summary>session-replay: 1.1.2</summary>

##
[1.1.2](session-replay-1.1.1...session-replay-1.1.2)
(2026-04-01)


### Bug Fixes

* OIDC publishing with npm
([#454](#454))
([ab4221b](ab4221b))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: this PR only updates release metadata (versions and
changelogs) with no functional code changes.
> 
> **Overview**
> Cuts a patch release for `@launchdarkly/observability` and
`@launchdarkly/session-replay`, bumping both from `1.1.1` to `1.1.2` in
the release manifest and each package’s `package.json`.
> 
> Updates both `CHANGELOG.md` files to document the `1.1.2` bug fix:
*OIDC publishing with npm*.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
f91f726. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
abelonogov-ld added a commit that referenced this pull request Apr 3, 2026
* main:
  chore: release main (#455)
  fix: OIDC publishing with npm (#454)
  chore: [SEC-7924] pin third-party GitHub Actions to commit SHAs (#452)
abelonogov-ld added a commit that referenced this pull request Apr 3, 2026
* main:
  chore: release main (#459)
  feat: Android Distro vs Sdk OpenTelemetry naming (#458)
  chore: release main (#455)
  fix: OIDC publishing with npm (#454)
  chore: [SEC-7924] pin third-party GitHub Actions to commit SHAs (#452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@launchdarkly/session-replay@1.1.0 published with unresolved workspace:* dependency

3 participants