feat: Add Big Segment store support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $excludeRefs = $this->connection->sMembers($this->prefix . self::KEY_CONTEXT_EXCLUDE . $contextHash); | ||
| } catch (Exception $e) { | ||
| $this->logger->warning('Error getting big segment membership from Redis', ['exception' => $e->getMessage()]); | ||
| return null; |
There was a problem hiding this comment.
Same comment as in other PRs on nullable returns of this interface.
tanderson-ld
approved these changes
Jan 17, 2025
keelerm84
force-pushed
the
mk/sdk-1035/big-segment
branch
8 times, most recently
from
e4b2f2c to
6fe7133
Compare
Release-As: 2.0.0
keelerm84
force-pushed
the
mk/sdk-1035/big-segment
branch
from
6fe7133 to
a7d69a3
Compare
keelerm84
pushed a commit
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](1.3.0...2.0.0) (2025-01-17) ### Features * Add Big Segment store support ([#25](#25)) ([9c6ca70](9c6ca70)) * Bump LaunchDarkly to 6.4.0+ ([25c899d](25c899d)) * Bump PHP to 8.1+ ([25c899d](25c899d)) * FeatureRequester requires configured Redis instance ([6bcfdbd](6bcfdbd)) ### Miscellaneous Chores * Add missing documentation on big segments store method ([c087baa](c087baa)) * Add psalm and cs-checker ([6aaaaa4](6aaaaa4)) * Cleanup and strict types ([8c0f461](8c0f461)) * Fix doc generation action ([#22](#22)) ([d6ba2c9](d6ba2c9)) * Inline shared test package ([c0e4524](c0e4524)) * Run `composer cs-fix` to improve style ([32cfaf1](32cfaf1)) * Update type hints to quiet psalm ([ccb15fe](ccb15fe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release-As: 2.0.0