Skip to content

fix: php 8.4 deprecation for implicitly nullable parameters #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

david-zelty
Copy link
Contributor

@david-zelty david-zelty commented Mar 15, 2025

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Describe the solution you've provided

Add explicit nullable on related parameters.

Describe alternatives you've considered

Depending your code convention, null|* syntax could be used, but I saw that you use ?* syntax on others files when object can be nullable.

Additional context

N/A

@keelerm84 keelerm84 merged commit 1143a16 into launchdarkly:main Mar 17, 2025
10 checks passed
@keelerm84
Copy link
Member

Thank you so much for your contribution!

keelerm84 pushed a commit that referenced this pull request Mar 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.5.1](6.5.0...6.5.1)
(2025-03-17)


### Bug Fixes

* php 8.4 deprecation for implicitly nullable parameters
([#219](#219))
([1143a16](1143a16))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants