Closed
Conversation
Contributor
Author
|
nonsense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
equal?dedup in hot scalar/domain helper paths with serialized string keysextract_tblvarsextract_columns_for_tblvarextract_outer_columns_for_tblvarunnest_expr_outer_refsWhy
Large app queries compile through repeated planner traversals over the same nested scalar and permission terms. This PR reduces repeated term analysis without changing lowering semantics.
Validation
python3 run_sql_tests.py tests/32_expr_subselects.yamlpython3 run_sql_tests.py tests/117_dashboard_unnesting_regressions.yamlmake testwas started locally and ran through the broad suite without failures in the observed output; CI will provide the definitive full runCold benchmark
Fresh restart / fresh in-memory queryplan cache, same copied app data and badge query:
master:28.78s29.09sSo the branch is currently correctness-safe but benchmark-neutral on that exact homepage badge query. I am still opening it because the optimization direction is general and the changes are isolated enough for CI review.