Skip to content

All: Translation: Update zh_CN.po#15075

Open
qx100 wants to merge 1 commit intolaurent22:devfrom
qx100:dev
Open

All: Translation: Update zh_CN.po#15075
qx100 wants to merge 1 commit intolaurent22:devfrom
qx100:dev

Conversation

@qx100
Copy link
Copy Markdown
Contributor

@qx100 qx100 commented Apr 12, 2026

Update Simplified Chinese (zh_CN) translation

Please review and let me know if any changes are needed.
Thanks!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 12, 2026

📝 Walkthrough

Walkthrough

Updated Chinese (Simplified) translation file with revised metadata and numerous translated strings. Multiple phrasing adjustments and punctuation corrections were made across CLI and UI messages. Fuzzy flags were removed from selected entries and msgstr values were updated accordingly.

Changes

Cohort / File(s) Summary
Localisation Updates
packages/tools/locales/zh_CN.po
Revised translator metadata and Poedit version. Filled in and adjusted Chinese translations for image descriptions, command/key labels, UI prompts and banners. Corrected phrasing across CLI/UI messages, removed fuzzy flags from entries, adjusted line breaks and punctuation in longer sentences.

Suggested labels

translation

Suggested reviewers

  • tessus

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Pr Description Must Follow Guidelines ❌ Error PR description does not follow Joplin guidelines, missing required Problem, Solution, Test Plan, and AI Assistance Disclosure sections. Add Problem section explaining translation issues, Solution section describing changes, Test Plan documenting verification, and mandatory AI Assistance Disclosure statement.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, explicitly mentioning the update to Simplified Chinese (zh_CN) translation and requesting review of the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'All: Translation: Update zh_CN.po' clearly and specifically describes the main change—updating the Simplified Chinese translation file. It directly corresponds to the changeset which consists entirely of translation updates in the zh_CN.po file.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the translation i18n and l10n label Apr 12, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/tools/locales/zh_CN.po`:
- Around line 352-354: The zh_CN translation reverses the two %s placeholders
compared to the source msgid "Accepted: Notebook %s from %s": update the msgstr
for that entry so the notebook placeholder appears first and the user second
(e.g. change "已接受:来自 %s 的笔记本 %s" to "已接受:笔记本 %s 来自 %s") so the rendered order
matches the original.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a208750b-4301-4016-b110-7b238cbf44f4

📥 Commits

Reviewing files that changed from the base of the PR and between f545726 and a0d0cbc.

📒 Files selected for processing (1)
  • packages/tools/locales/zh_CN.po

Comment on lines 352 to +354
#: packages/app-cli/app/command-share.ts:179
msgid "Accepted: Notebook %s from %s"
msgstr "已接受邀请:笔记本 %s (来自%s)"
msgstr "已接受:来自 %s 的笔记本 %s"
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Placeholder order is inverted in the accepted-share string.

At Line 354, the %s values are rendered in the opposite semantic order of the source (Notebook %s from %s), so notebook/user will be displayed incorrectly.

Proposed fix
-msgstr "已接受:来自 %s 的笔记本 %s"
+msgstr "已接受:笔记本 %s,来自 %s"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/tools/locales/zh_CN.po` around lines 352 - 354, The zh_CN
translation reverses the two %s placeholders compared to the source msgid
"Accepted: Notebook %s from %s": update the msgstr for that entry so the
notebook placeholder appears first and the user second (e.g. change "已接受:来自 %s
的笔记本 %s" to "已接受:笔记本 %s 来自 %s") so the rendered order matches the original.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qx100 I don't speak Chinese, thus I cannot determine whether this is in fact a problem.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed a problem. To keep the style of your translation with the correct placeholder order, you can try this

msgstr "已接受:来自 %2$s 的笔记本 %1$s"

reference
example

@tessus tessus changed the title Update zh_CN translations All: Translation: Update zh_CN.po Apr 12, 2026
Copy link
Copy Markdown
Contributor

@wh201906 wh201906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your translation!

"Accelerator \"%s\" is used for \"%s\" and \"%s\" commands. This may lead to "
"unexpected behaviour."
msgstr "加速键 “%s” 被用于 “%s” 和 “%s” 命令。这可能导致意外行为。"
msgstr "快捷键“%s” 被用于 “%s” 和 “%s” 命令。这可能导致意外行为。"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a typo

Suggested change
msgstr "快捷键“%s” 被用于 “%s” 和 “%s” 命令。这可能导致意外行为。"
msgstr "快捷键 “%s” 被用于 “%s” 和 “%s” 命令。这可能导致意外行为。"

#: packages/app-desktop/gui/SyncWizard/Dialog.tsx:165
msgid "Check"
msgstr "勾选"
msgstr "检查"
Copy link
Copy Markdown
Contributor

@wh201906 wh201906 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source code here seems to be a state indicator for accessibility, so the text should be translated like "已选中" (and “未选中” for "Not checked").
The original text is somewhat misleading I guess. It should be "Checked"

<FeatureIcon className={className} role='img' aria-label={enabled ? _('Check') : _('Not checked')}/>

Suggested change
msgstr "检查"
msgstr "已选中"

#: packages/app-cli/app/command-export.ts:24
msgid "Destination format: %s"
msgstr "目标格式:%s"
msgstr "导出格式:%s"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally suggest not to change the translation here. "Destination" cannot be translated to "导出". I guess you derived "导出" from the context that it's from command-export.ts, but this translation could change the meaning which the developers want to express.

@tessus
Copy link
Copy Markdown
Collaborator

tessus commented Apr 14, 2026

@wh201906 thanks a lot for your review and comments. I'll let you 2 sort this out. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation i18n and l10n

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants